Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: tests/standalone/io/http_client_request_test.dart

Issue 14055003: Remove HttpClientRequest.response, as it's identical to HttpClientRequest.done. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/http_impl.dart ('k') | tests/standalone/io/http_headers_state_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/http_client_request_test.dart
diff --git a/tests/standalone/io/http_client_request_test.dart b/tests/standalone/io/http_client_request_test.dart
index 3fd108c2c327a71ed8a3919bb90efdab8e2ac046..7d77c032a8dd77dbfeec1da0b49804596640f73d 100644
--- a/tests/standalone/io/http_client_request_test.dart
+++ b/tests/standalone/io/http_client_request_test.dart
@@ -35,13 +35,12 @@ void testClientRequest(void handler(request)) {
void testResponseDone() {
testClientRequest((request) {
- request.close();
- request.done.then((res1) {
- request.response.then((res2) {
+ request.close().then((res1) {
+ request.done.then((res2) {
Expect.equals(res1, res2);
});
});
- return request.response;
+ return request.done;
});
}
@@ -54,7 +53,7 @@ void testBadResponseAdd() {
request.done.catchError((error) {
port.close();
}, test: (e) => e is HttpException);
- return request.response;
+ return request.done;
});
testClientRequest((request) {
@@ -66,7 +65,7 @@ void testBadResponseAdd() {
request.done.catchError((error) {
port.close();
}, test: (e) => e is HttpException);
- return request.response;
+ return request.done;
});
testClientRequest((request) {
@@ -79,7 +78,7 @@ void testBadResponseAdd() {
request.done.catchError((error) {
port.close();
}, test: (e) => e is HttpException);
- return request.response;
+ return request.done;
});
}
@@ -91,7 +90,7 @@ void testBadResponseClose() {
request.done.catchError((error) {
port.close();
}, test: (e) => e is HttpException);
- return request.response;
+ return request.done;
});
testClientRequest((request) {
@@ -102,7 +101,7 @@ void testBadResponseClose() {
request.done.catchError((error) {
port.close();
}, test: (e) => e is HttpException);
- return request.response;
+ return request.done;
});
}
« no previous file with comments | « sdk/lib/io/http_impl.dart ('k') | tests/standalone/io/http_headers_state_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698