Remove methods on StackTrace class.

Remove methods on StackTrace class.

The API is not ready for finalization, so we remove it for further
development after M4.

Makes dart2js's StackTrace object implement dart:core's StackTrace.
Marks dart2js stack-trace tests as Fail instead of Skip.

Committed: https://code.google.com/p/dart/source/detail?r=21437

[kasperl, 2013-04-11 09:29:48]

LGTM.

https://codereview.chromium.org/14009004/diff/1/sdk/lib/core/stacktrace.dart
File sdk/lib/core/stacktrace.dart (right):

https://codereview.chromium.org/14009004/diff/1/sdk/lib/core/stacktrace.dart#...
sdk/lib/core/stacktrace.dart:22: * typically 'main'.
In an event driven program, I'm not sure the entry function really is typically
main.

https://codereview.chromium.org/14009004/diff/1/tests/language/full_stacktrac...
File tests/language/full_stacktrace1_test.dart (right):

https://codereview.chromium.org/14009004/diff/1/tests/language/full_stacktrac...
tests/language/full_stacktrace1_test.dart:20: var full_trace = s.toString();
full_trace -> fullTrace

https://codereview.chromium.org/14009004/diff/1/tests/language/full_stacktrac...
File tests/language/full_stacktrace2_test.dart (right):

https://codereview.chromium.org/14009004/diff/1/tests/language/full_stacktrac...
tests/language/full_stacktrace2_test.dart:20: var full_trace = s.toString();
full_trace -> fullTrace

https://codereview.chromium.org/14009004/diff/1/tests/language/full_stacktrac...
tests/language/full_stacktrace2_test.dart:42: var full_trace = s.toString();
Ditto.

https://codereview.chromium.org/14009004/diff/1/tests/language/full_stacktrac...
File tests/language/full_stacktrace3_test.dart (right):

https://codereview.chromium.org/14009004/diff/1/tests/language/full_stacktrac...
tests/language/full_stacktrace3_test.dart:20: var full_trace = s.toString();
fullTrace

https://codereview.chromium.org/14009004/diff/1/tests/language/full_stacktrac...
tests/language/full_stacktrace3_test.dart:40: var full_trace = s.toString();
Ditto.

https://codereview.chromium.org/14009004/diff/1/tests/language/language_dart2...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/14009004/diff/1/tests/language/language_dart2...
tests/language/language_dart2js.status:30: # Fails due to inlining. Not all
expected frames are in the trace.
File tracking bug?

[Lasse Reichstein Nielsen, 2013-04-11 11:14:21]

https://codereview.chromium.org/14009004/diff/1/tests/language/language_dart2...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/14009004/diff/1/tests/language/language_dart2...
tests/language/language_dart2js.status:30: # Fails due to inlining. Not all
expected frames are in the trace.
The bug really is that the test is testing functionality that isn't guaranteed.
Would it be better to make the test a VM-only test?

[Ivan Posva, 2013-04-12 03:13:10]

LGTM after addressing comments.

-ivan

https://codereview.chromium.org/14009004/diff/8001/runtime/lib/stacktrace_pat...
File runtime/lib/stacktrace_patch.dart (left):

https://codereview.chromium.org/14009004/diff/8001/runtime/lib/stacktrace_pat...
runtime/lib/stacktrace_patch.dart:6: /* patch */ String get fullStackTrace
native "Stacktrace_getFullStacktrace";
Instead of removing them here, please mark them private so we can use them to
debug when we have issues in the core libraries.

https://codereview.chromium.org/14009004/diff/8001/tests/language/full_stackt...
File tests/language/full_stacktrace2_test.dart (right):

https://codereview.chromium.org/14009004/diff/8001/tests/language/full_stackt...
tests/language/full_stacktrace2_test.dart:8: // This might not be the case if
inlining methods.
This is a current limitation of dart2js and not something that we should spell
out in the language tests as it sounds like it is part of the expectation.
We had been documenting this either in the status file or in a bug linked from
the status file.

https://codereview.chromium.org/14009004/diff/8001/tests/language/full_stackt...
File tests/language/full_stacktrace3_test.dart (right):

https://codereview.chromium.org/14009004/diff/8001/tests/language/full_stackt...
tests/language/full_stacktrace3_test.dart:1: // (c) 2013, the Dart project
authors.  Please see the AUTHORS file
Where is the difference between this file and full_stacktrace2_test.dart?

https://codereview.chromium.org/14009004/diff/8001/tests/language/language_da...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/14009004/diff/8001/tests/language/language_da...
tests/language/language_dart2js.status:30: # Fails due to inlining. Not all
expected frames are in the trace.
Yes, like documenting it here.

[Lasse Reichstein Nielsen, 2013-04-15 11:37:22]

https://codereview.chromium.org/14009004/diff/8001/runtime/lib/stacktrace_pat...
File runtime/lib/stacktrace_patch.dart (left):

https://codereview.chromium.org/14009004/diff/8001/runtime/lib/stacktrace_pat...
runtime/lib/stacktrace_patch.dart:6: /* patch */ String get fullStackTrace
native "Stacktrace_getFullStacktrace";
On 2013/04/12 03:13:10, Ivan Posva wrote:
> Instead of removing them here, please mark them private so we can use them to
> debug when we have issues in the core libraries.

Done.

https://codereview.chromium.org/14009004/diff/8001/tests/language/full_stackt...
File tests/language/full_stacktrace2_test.dart (right):

https://codereview.chromium.org/14009004/diff/8001/tests/language/full_stackt...
tests/language/full_stacktrace2_test.dart:8: // This might not be the case if
inlining methods.
I'll remove this for now, and keep it in the status files. The dart2js people
can the say whether they expect this to change in the future or not.

https://codereview.chromium.org/14009004/diff/8001/tests/language/full_stackt...
File tests/language/full_stacktrace3_test.dart (right):

https://codereview.chromium.org/14009004/diff/8001/tests/language/full_stackt...
tests/language/full_stacktrace3_test.dart:1: // (c) 2013, the Dart project
authors.  Please see the AUTHORS file
See below.

https://codereview.chromium.org/14009004/diff/8001/tests/language/full_stackt...
tests/language/full_stacktrace3_test.dart:29: throw new Exception("This is not a
rethrow");
This is a rethrow in full_stacktrace2_test.dart.

[Lasse Reichstein Nielsen, 2013-04-15 11:44:58]

Committed patchset #4 manually as r21437 (presubmit successful).