Remove methods on StackTrace class.

tests/language/full_stacktrace3_test.dart

 // (c) 2013, the Dart project authors.  Please see the AUTHORS file

[Ivan Posva, 2013/04/12 03:13:10]

Where is the difference between this file and full_stacktrace2_test.dart?

[Lasse Reichstein Nielsen, 2013/04/15 11:37:22]

See below.

 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import "package:expect/expect.dart";
 
+// This test assumes that all called functions occur in the stack trace.
+// This might not be the case if inlining methods.
+
 void func1() {
-  throw new Exception("Test peanut gallery request for Full stacktrace");
+  throw new Exception("Test full stacktrace");
 }
 void func2() {
   func1();
 }
 void func3() {
   try {
     func2();
   } on Object catch(e, s) {
-    print(e);
-    var full_trace = s.fullStackTrace;
-    Expect.isTrue(full_trace.contains("func1"));
-    Expect.isTrue(full_trace.contains("func2"));
-    Expect.isTrue(full_trace.contains("func3"));
-    Expect.isTrue(full_trace.contains("func4"));
-    Expect.isTrue(full_trace.contains("func5"));
-    Expect.isTrue(full_trace.contains("func6"));
-    Expect.isTrue(full_trace.contains("func7"));
-    Expect.isTrue(full_trace.contains("main"));
-
-    var trace = s.stackTrace;
-    Expect.isTrue(trace.contains("func1"));
-    Expect.isTrue(trace.contains("func2"));
-    Expect.isTrue(trace.contains("func3"));
-
-    Expect.isFalse(trace.contains("func4"));
-    Expect.isFalse(trace.contains("func5"));
-    Expect.isFalse(trace.contains("func6"));
-    Expect.isFalse(trace.contains("func7"));
-    Expect.isFalse(trace.contains("main"));
-
-    print(s);
-
-    print("Full stack trace");
-    print(full_trace);
-
-    print("Stack trace");
-    print(trace);
+    var fullTrace = s.toString();
+    Expect.isTrue(fullTrace.contains("func1"));
+    Expect.isTrue(fullTrace.contains("func2"));
+    Expect.isTrue(fullTrace.contains("func3"));
+    Expect.isTrue(fullTrace.contains("func4"));
+    Expect.isTrue(fullTrace.contains("func5"));
+    Expect.isTrue(fullTrace.contains("func6"));
+    Expect.isTrue(fullTrace.contains("func7"));
+    Expect.isTrue(fullTrace.contains("main"));
     throw new Exception("This is not a rethrow");

[Lasse Reichstein Nielsen, 2013/04/15 11:37:22]

This is a rethrow in full_stacktrace2_test.dart.

   }
 }
 int func4() {
   func3();
   return 1;
 }
 int func5() {
   try {
     func4();
   } on Object catch(e, s) {
-    var full_trace = s.fullStackTrace;
-    Expect.isFalse(full_trace.contains("func1"));
-    Expect.isFalse(full_trace.contains("func2"));
-    Expect.isTrue(full_trace.contains("func3"));
-    Expect.isTrue(full_trace.contains("func4"));
-    Expect.isTrue(full_trace.contains("func5"));
-    Expect.isTrue(full_trace.contains("func6"));
-    Expect.isTrue(full_trace.contains("func7"));
-    Expect.isTrue(full_trace.contains("main"));
-
-    var trace = s.stackTrace;
-    Expect.isFalse(trace.contains("func1"));
-    Expect.isFalse(trace.contains("func2"));
-
-    Expect.isTrue(trace.contains("func3"));
-    Expect.isTrue(trace.contains("func4"));
-    Expect.isTrue(trace.contains("func5"));
-
-    Expect.isFalse(trace.contains("func6"));
-    Expect.isFalse(trace.contains("func7"));
-    Expect.isFalse(trace.contains("main"));
-
-    print(s);
-
-    print("Full stack trace");
-    print(full_trace);
-
-    print("Stack trace");
-    print(trace);
+    var fullTrace = s.toString();
+    Expect.isFalse(fullTrace.contains("func1"));
+    Expect.isFalse(fullTrace.contains("func2"));
+    Expect.isTrue(fullTrace.contains("func3"));
+    Expect.isTrue(fullTrace.contains("func4"));
+    Expect.isTrue(fullTrace.contains("func5"));
+    Expect.isTrue(fullTrace.contains("func6"));
+    Expect.isTrue(fullTrace.contains("func7"));
+    Expect.isTrue(fullTrace.contains("main"));
   }
   return 1;
 }
 int func6() {
   func5();
   return 1;
 }
 int func7() {
   func6();
   return 1;
 }
 main() {
   var i = func7();
   Expect.equals(1, i);
 }