runtime/lib/stacktrace_patch.dart - Issue 14009004: Remove methods on StackTrace class.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/lib/stacktrace_patch.dart

Issue 14009004: Remove methods on StackTrace class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 patch class StackTrace {	5 patch class StackTrace {

6 /* patch */ String get fullStackTrace native "Stacktrace_getFullStacktrace";
Ivan Posva 2013/04/12 03:13:10 Instead of removing them here, please mark them pr Instead of removing them here, please mark them private so we can use them to debug when we have issues in the core libraries. Lasse Reichstein Nielsen 2013/04/15 11:37:22 Done. Show quoted text On 2013/04/12 03:13:10, Ivan Posva wrote: > Instead of removing them here, please mark them private so we can use them to > debug when we have issues in the core libraries. Done.
7

8 /* patch */ String get stackTrace native "Stacktrace_getStacktrace";

9

10 /* patch */ void _setupFullStackTrace()	6 /* patch */ void _setupFullStackTrace()

11 native "Stacktrace_setupFullStacktrace";	7 native "Stacktrace_setupFullStacktrace";

12 }	8 }

13	9

OLD	NEW