Issue 13983016: Support debugger API on ARM.

Issue 13983016: Support debugger API on ARM. (Closed)

Created:
7 years, 8 months ago by regis

Modified:
7 years, 8 months ago

Reviewers:
zra

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Support debugger API on ARM. Support smull ARM instruction in order to detect 32-bit multiplication overflow. Enable debugger api tests on ARM. Enable isolate tests on ARM. Enable code descriptors tests on ARM. Enable snapshot tests on ARM. Enable heap tests on ARM. Committed: https://code.google.com/p/dart/source/detail?r=21890

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+248 lines, -57 lines)			Patch
M	runtime/vm/assembler_arm.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm_test.cc	View	1	2 chunks	+19 lines, -4 lines	0 comments	Download
M	runtime/vm/code_descriptors_test.cc	View	1	3 chunks	+6 lines, -2 lines	0 comments	Download
M	runtime/vm/debugger_api_impl_test.cc	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	runtime/vm/debugger_arm.cc	View	1	1 chunk	+34 lines, -6 lines	0 comments	Download
M	runtime/vm/debugger_ia32.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/debugger_x64.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/disassembler_arm.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/heap_test.cc	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1	3 chunks	+49 lines, -17 lines	0 comments	Download
M	runtime/vm/isolate_test.cc	View	1	2 chunks	+7 lines, -3 lines	0 comments	Download
M	runtime/vm/object_store.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/simulator_arm.cc	View	1	2 chunks	+22 lines, -2 lines	0 comments	Download
M	runtime/vm/simulator_mips.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1	3 chunks	+73 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

lgtm https://codereview.chromium.org/13983016/diff/1/runtime/vm/disassembler_arm.cc File runtime/vm/disassembler_arm.cc (right): https://codereview.chromium.org/13983016/diff/1/runtime/vm/disassembler_arm.cc#newcode641 runtime/vm/disassembler_arm.cc:641: case 6: { Fix indentation. https://codereview.chromium.org/13983016/diff/1/runtime/vm/simulator_arm.cc File runtime/vm/simulator_arm.cc ...

7 years, 8 months ago (2013-04-23 15:57:02 UTC) #2

regis

Thanks! https://codereview.chromium.org/13983016/diff/1/runtime/vm/disassembler_arm.cc File runtime/vm/disassembler_arm.cc (right): https://codereview.chromium.org/13983016/diff/1/runtime/vm/disassembler_arm.cc#newcode641 runtime/vm/disassembler_arm.cc:641: case 6: { On 2013/04/23 15:57:02, zra wrote: ...

7 years, 8 months ago (2013-04-23 16:05:16 UTC) #3

regis

7 years, 8 months ago (2013-04-23 16:10:41 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21890 (presubmit successful).

Expand Messages | Collapse Messages