Use intermediate file containing javac arguments to overcome windows limitations

Use intermediate file containing javac arguments to overcome windows limitations

Committed: https://code.google.com/p/dart/source/detail?r=21362

[kustermann, 2013-04-11 10:32:37]

Would be nice if you could take a careful look at this (since I'm not a gyp
master yet).

One note: When people add new java files, they need to run 'gclient runhooks' (I
think it's the same for building the editor).

[ahe, 2013-04-11 11:40:30]

Perhaps you should do something similar to
dart/compiler/scripts/generate_my_projects.py.

https://codereview.chromium.org/13982010/diff/2001/editor/analyzer.gyp
File editor/analyzer.gyp (right):

https://codereview.chromium.org/13982010/diff/2001/editor/analyzer.gyp#newcode21
editor/analyzer.gyp:21: 'dependencies' : ['analyzer_sources_file'],
Delete this.

https://codereview.chromium.org/13982010/diff/2001/editor/analyzer.gyp#newcode31
editor/analyzer.gyp:31: '<(PRODUCT_DIR)/analyzer_sources.txt',
This should go in INTERMEDIATE_DIR.

See https://code.google.com/p/gyp/wiki/InputFormatReference#Predefined_Variables

https://codereview.chromium.org/13982010/diff/2001/editor/analyzer.gyp#newcode46
editor/analyzer.gyp:46: '@<(PRODUCT_DIR)/analyzer_sources.txt', # The @filename
means: read command line options from file.
INTERMEDIATE_DIR

https://codereview.chromium.org/13982010/diff/2001/editor/analyzer.gyp#newcode46
editor/analyzer.gyp:46: '@<(PRODUCT_DIR)/analyzer_sources.txt', # The @filename
means: read command line options from file.
Unnecessarily long line.

https://codereview.chromium.org/13982010/diff/2001/editor/analyzer.gyp#newcode54
editor/analyzer.gyp:54: 'type': 'none',
Delete the extra target.

https://codereview.chromium.org/13982010/diff/2001/editor/analyzer.gyp#newcode55
editor/analyzer.gyp:55: 'variables': {
Move variables back to where it was before.

https://codereview.chromium.org/13982010/diff/2001/editor/analyzer.gyp#newcode58
editor/analyzer.gyp:58: '<!@(["python", "../tools/list_files.py", "\\.java$",
"tools/plugins/com.google.dart.engine"])',
This can be one command.

https://codereview.chromium.org/13982010/diff/2001/editor/analyzer.gyp#newcode70
editor/analyzer.gyp:70: '<(PRODUCT_DIR)/analyzer_sources.txt',
INTERMEDIATE_DIR

https://codereview.chromium.org/13982010/diff/2001/editor/analyzer.gyp#newcode75
editor/analyzer.gyp:75: '<(PRODUCT_DIR)/analyzer_sources.txt',
INTERMEDIATE_DIR

https://codereview.chromium.org/13982010/diff/2001/tools/generate_sources_fil...
File tools/generate_sources_file.py (right):

https://codereview.chromium.org/13982010/diff/2001/tools/generate_sources_fil...
tools/generate_sources_file.py:6: # Usage: generate_sources_file.py
<output-file> <pattern> <directory, ...>
This should be a documentation string.

[ricow1, 2013-04-11 12:16:30]

https://codereview.chromium.org/13982010/diff/2001/editor/analyzer.gyp
File editor/analyzer.gyp (right):

https://codereview.chromium.org/13982010/diff/2001/editor/analyzer.gyp#newcode31
editor/analyzer.gyp:31: '<(PRODUCT_DIR)/analyzer_sources.txt',
On 2013/04/11 11:40:31, ahe wrote:
> This should go in INTERMEDIATE_DIR.
> 
> See
https://code.google.com/p/gyp/wiki/InputFormatReference#Predefined_Variables

Shouldn't this go to SHARED_INTERMEDIATE to guarantee that it is available
across targets?

https://codereview.chromium.org/13982010/diff/2001/editor/analyzer.gyp#newcode46
editor/analyzer.gyp:46: '@<(PRODUCT_DIR)/analyzer_sources.txt', # The @filename
means: read command line options from file.
On 2013/04/11 11:40:31, ahe wrote:
> INTERMEDIATE_DIR
Same question as above

[ahe, 2013-04-11 13:30:27]

https://codereview.chromium.org/13982010/diff/2001/editor/analyzer.gyp
File editor/analyzer.gyp (right):

https://codereview.chromium.org/13982010/diff/2001/editor/analyzer.gyp#newcode31
editor/analyzer.gyp:31: '<(PRODUCT_DIR)/analyzer_sources.txt',
On 2013/04/11 12:16:31, ricow1 wrote:
> On 2013/04/11 11:40:31, ahe wrote:
> > This should go in INTERMEDIATE_DIR.
> > 
> > See
> https://code.google.com/p/gyp/wiki/InputFormatReference#Predefined_Variables
> 
> Shouldn't this go to SHARED_INTERMEDIATE to guarantee that it is available
> across targets?

I'm suggesting that Martin eliminate the extra target.  It is not necessary.

[kustermann, 2013-04-11 18:40:43]

PTAL

Two notes:
- The build is incremental on linux but not on windows (any ideas?)
- If additional java files are added this will not be detected.

[ricow1, 2013-04-12 11:44:37]

LGTM, please let peter have a look as well

[ahe, 2013-04-12 15:06:49]

LGTM except for check_call

https://codereview.chromium.org/13982010/diff/21001/editor/tools/compile_anal...
File editor/tools/compile_analyzer.py (right):

https://codereview.chromium.org/13982010/diff/21001/editor/tools/compile_anal...
editor/tools/compile_analyzer.py:51: subprocess.check_call(cmd)
Unfortunately, we cannot use check_call as it isn't available on older mac
versions.

[kustermann, 2013-04-12 15:18:08]

https://codereview.chromium.org/13982010/diff/21001/editor/tools/compile_anal...
File editor/tools/compile_analyzer.py (right):

https://codereview.chromium.org/13982010/diff/21001/editor/tools/compile_anal...
editor/tools/compile_analyzer.py:51: subprocess.check_call(cmd)
On 2013/04/12 15:06:49, ahe wrote:
> Unfortunately, we cannot use check_call as it isn't available on older mac
> versions.

Done.

[kustermann, 2013-04-12 15:20:03]

Committed patchset #5 manually as r21362 (presubmit successful).