Use intermediate file containing javac arguments to overcome windows limitations

editor/analyzer.gyp

 # Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 {
   'variables': {
     'analyzer_name': 'dartanalyzer',
      # When changing the jar files that we depend on please change the list
      # below.
      'dependent_jar_files': [
        '../third_party/commons-lang/3.1/commons-lang3-3.1.jar',
        '../third_party/json/r2_20080312/json.jar',
        '../third_party/guava/r13/guava-13.0.1.jar',
        '../third_party/args4j/2.0.12/args4j-2.0.12.jar'
      ],
   },
   'targets': [
     {
       'target_name': 'analyzer',
       'type': 'none',
+      'dependencies' : ['analyzer_sources_file'],

[ahe, 2013/04/11 11:40:31]

Delete this.

       'variables': {
-        'java_source_files': [
-          '<!@(["python", "../tools/list_files.py", "\\.java$", "tools/plugins/com.google.dart.command.analyze"])',
-          '<!@(["python", "../tools/list_files.py", "\\.java$", "tools/plugins/com.google.dart.engine"])',
-        ],
         # The file where we write the class path to be used in the manifest.
         'class_path_file': '<(PRODUCT_DIR)/<(analyzer_name)/classpath_file',
       },
       'actions': [
         {
           'action_name': 'create_analyzer',
           'inputs': [
-            '<@(java_source_files)',
+            'tools/compile_analyzer.py',
+            '<(PRODUCT_DIR)/analyzer_sources.txt',

[ahe, 2013/04/11 11:40:31]

This should go in INTERMEDIATE_DIR.

See https://code.google.com/p/gyp/wiki/InputFormatReference#Predefined_Variables

[ricow1, 2013/04/11 12:16:31]

Shouldn't this go to SHARED_INTERMEDIATE to guarantee that it is available
across targets?

[ahe, 2013/04/11 13:30:27]

I'm suggesting that Martin eliminate the extra target.  It is not necessary.

             '<@(dependent_jar_files)',
-            'tools/compile_analyzer.py',
           ],
           'outputs': [
             '<(PRODUCT_DIR)/<(analyzer_name)/<(analyzer_name).jar',
           ],
           'action': [
             'python',
             'tools/compile_analyzer.py',
             '--output_dir', '<(PRODUCT_DIR)/<(analyzer_name)/',
             '--jar_file_name', '<(analyzer_name).jar',
             '--jar_entry_directory', 'com',
             '--dependent_jar_files', '"<@(dependent_jar_files)"',
             '--entry_point', 'com.google.dart.command.analyze.AnalyzerMain',
             '--class_path_file', 'classpath_file',
-            '<@(java_source_files)',
+            '@<(PRODUCT_DIR)/analyzer_sources.txt', # The @filename means: read command line options from file.

[ahe, 2013/04/11 11:40:31]

INTERMEDIATE_DIR

[ahe, 2013/04/11 11:40:31]

Unnecessarily long line.

[ricow1, 2013/04/11 12:16:31]

Same question as above

           ],
           'message': 'Creating <(_outputs).',
         },
+      ],
+    },
+    {
+      'target_name': 'analyzer_sources_file',
+      'type': 'none',

[ahe, 2013/04/11 11:40:31]

Delete the extra target.

+      'variables': {

[ahe, 2013/04/11 11:40:31]

Move variables back to where it was before.

+        'java_source_files': [
+          '<!@(["python", "../tools/list_files.py", "\\.java$", "tools/plugins/com.google.dart.command.analyze"])',
+          '<!@(["python", "../tools/list_files.py", "\\.java$", "tools/plugins/com.google.dart.engine"])',

[ahe, 2013/04/11 11:40:31]

This can be one command.

+        ],
+      },
+      'actions': [
+        {
+          'action_name': 'generate_analzer_sources_file',
+          'inputs': [
+            '<@(java_source_files)',
+            'tools/compile_analyzer.py',
+            '../tools/generate_sources_file.py',
+          ],
+          'outputs': [
+            '<(PRODUCT_DIR)/analyzer_sources.txt',

[ahe, 2013/04/11 11:40:31]

INTERMEDIATE_DIR

+          ],
+          'action': [
+            'python',
+            '../tools/generate_sources_file.py',
+            '<(PRODUCT_DIR)/analyzer_sources.txt',

[ahe, 2013/04/11 11:40:31]

INTERMEDIATE_DIR

+            '\\.java',
+            'tools/plugins/com.google.dart.command.analyze',
+            'tools/plugins/com.google.dart.engine',
+          ],
+          'message': 'Creating <(_outputs).',
+        },
       ],
     },
   ]
 }