Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: editor/tools/compile_analyzer.py

Issue 13982010: Use intermediate file containing javac arguments to overcome windows limitations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « editor/analyzer.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/compile_analyzer.py
diff --git a/editor/tools/compile_analyzer.py b/editor/tools/compile_analyzer.py
index 0a4e3eab17e6f9ddcac2d4093b043fc11815e91b..b1b6edb3e9c3747c0789c31b9064811688a230aa 100644
--- a/editor/tools/compile_analyzer.py
+++ b/editor/tools/compile_analyzer.py
@@ -35,7 +35,10 @@ def GetOptions():
def CompileAnalyzer(options, args):
# We rely on all jar files being copied to the output dir.
- class_path = options.output_dir + '*'
+ if sys.platform == 'win32':
+ class_path = options.output_dir + '*;'
+ else:
+ class_path = options.output_dir + '*'
cmd = [GetJavacPath(),
'-sourcepath', 'foobar',
'-source', '6',
@@ -45,7 +48,9 @@ def CompileAnalyzer(options, args):
'-cp', class_path,
]
cmd.extend(args)
- subprocess.call(cmd)
+ exit_code = subprocess.call(cmd)
+ if exit_code:
+ raise Exception("Executing command [%s] failed" % cmd)
def CreateJarFile(options):
class_path_file_name = options.output_dir + options.class_path_file
@@ -53,7 +58,9 @@ def CreateJarFile(options):
cmd = [GetJarToolPath(), 'cfem', jar_file_name, options.entry_point,
class_path_file_name,
'-C', options.output_dir, options.jar_entry_directory]
- subprocess.call(cmd)
+ exit_code = subprocess.call(cmd)
+ if exit_code:
+ raise Exception("Executing command [%s] failed" % cmd)
def CopyFiles(options):
# Strip " from the string
« no previous file with comments | « editor/analyzer.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698