Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 13940015: Allow using native JS []= on typed data lists. (Closed)

Created:
7 years, 8 months ago by kasperl
Modified:
7 years, 8 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow using native JS []= on typed data lists. R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=21938

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -24 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/interceptors.dart View 1 chunk +12 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_array.dart View 1 chunk +1 line, -1 line 1 comment Download
M sdk/lib/_internal/compiler/implementation/lib/js_helper.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart View 2 chunks +2 lines, -2 lines 1 comment Download
M sdk/lib/_internal/compiler/implementation/ssa/nodes.dart View 1 chunk +8 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/optimize.dart View 2 chunks +2 lines, -11 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/types.dart View 2 chunks +14 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/value_range_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/utils/dummy_compiler_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/utils/recursive_import_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kasperl
7 years, 8 months ago (2013-04-24 10:26:16 UTC) #1
kasperl
https://codereview.chromium.org/13940015/diff/1/sdk/lib/_internal/compiler/implementation/lib/js_array.dart File sdk/lib/_internal/compiler/implementation/lib/js_array.dart (right): https://codereview.chromium.org/13940015/diff/1/sdk/lib/_internal/compiler/implementation/lib/js_array.dart#newcode297 sdk/lib/_internal/compiler/implementation/lib/js_array.dart:297: class JSMutableArray extends JSArray implements JSMutableIndexable {} I'll see ...
7 years, 8 months ago (2013-04-24 10:43:03 UTC) #2
ngeoffray
LGTM!
7 years, 8 months ago (2013-04-24 11:00:24 UTC) #3
kasperl
7 years, 8 months ago (2013-04-24 11:04:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21938 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698