Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart

Issue 13940015: Allow using native JS []= on typed data lists. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart b/sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart
index 8e8009463eda5b1e4d50cf3ff2389eca7ce08f73..d8635f6a156215f0960111210eb3baf0e90916c6 100644
--- a/sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart
+++ b/sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart
@@ -550,13 +550,14 @@ class SsaValueRangeAnalyzer extends HBaseVisitor implements OptimizationPhase {
*/
final Map<HInstruction, Range> ranges = new Map<HInstruction, Range>();
+ final Compiler compiler;
final ConstantSystem constantSystem;
final ValueRangeInfo info;
CodegenWorkItem work;
HGraph graph;
- SsaValueRangeAnalyzer(constantSystem, this.work)
+ SsaValueRangeAnalyzer(this.compiler, constantSystem, this.work)
: info = new ValueRangeInfo(constantSystem),
this.constantSystem = constantSystem;
@@ -629,7 +630,7 @@ class SsaValueRangeAnalyzer extends HBaseVisitor implements OptimizationPhase {
Range visitFieldGet(HFieldGet fieldGet) {
if (!fieldGet.isInteger()) return info.newUnboundRange();
- if (!fieldGet.receiver.isIndexablePrimitive()) {
+ if (!fieldGet.receiver.isIndexable(compiler)) {
return visitInstruction(fieldGet);
}
LengthValue value = info.newLengthValue(fieldGet);

Powered by Google App Engine
This is Rietveld 408576698