sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart - Issue 13940015: Allow using native JS []= on typed data lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart

Issue 13940015: Allow using native JS []= on typed data lists. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/lib/js_array.dart ('K') | « sdk/lib/_internal/compiler/implementation/lib/js_helper.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart b/sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart

index 3eb366892bce7694e68afaf106949c00fc7e7c6d..74e40bfc0f003ddef0fad3d6bd98c53605f25968 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart

@@ -99,7 +99,7 @@ class IndexAssignSpecializer extends InvokeDynamicSpecializer {

HInstruction tryConvertToBuiltin(HInvokeDynamic instruction,

Compiler compiler) {

- if (instruction.inputs[1].isMutableArray()) {

+ if (instruction.inputs[1].isMutableIndexable(compiler)) {

return new HIndexAssign(instruction.inputs[1],

instruction.inputs[2],

instruction.inputs[3],

@@ -129,7 +129,7 @@ class IndexSpecializer extends InvokeDynamicSpecializer {

HInstruction tryConvertToBuiltin(HInvokeDynamic instruction,

Compiler compiler) {

- if (instruction.inputs[1].isIndexablePrimitive()) {

+ if (instruction.inputs[1].isIndexable(compiler)) {

return new HIndex(

instruction.inputs[1], instruction.inputs[2], instruction.selector);

}