Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Issue 138913016: Fix flag to switch write protection of code pages on/off. (Closed)

Created:
6 years, 10 months ago by Florian Schneider
Modified:
6 years, 10 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, ricow1
Visibility:
Public.

Description

Fix flag to switch write protection of code pages on/off. TBR=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=32549

Patch Set 1 #

Patch Set 2 : fixed test to match expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M runtime/vm/object.cc View 2 chunks +4 lines, -1 line 0 comments Download
M runtime/vm/object_test.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/virtual_memory.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/virtual_memory_android.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/virtual_memory_linux.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/virtual_memory_macos.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/virtual_memory_win.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Florian Schneider
6 years, 10 months ago (2014-02-11 10:14:04 UTC) #1
Florian Schneider
6 years, 10 months ago (2014-02-11 10:17:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r32549 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698