runtime/vm/virtual_memory_android.cc - Issue 138913016: Fix flag to switch write protection of code pages on/off.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/vm/virtual_memory_android.cc

Issue 138913016: Fix flag to switch write protection of code pages on/off. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: fixed test to match expectation Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 #include "vm/globals.h"	5 #include "vm/globals.h"

6 #if defined(TARGET_OS_ANDROID)	6 #if defined(TARGET_OS_ANDROID)

7	7

8 #include "vm/virtual_memory.h"	8 #include "vm/virtual_memory.h"

9	9

10 #include <sys/mman.h> // NOLINT	10 #include <sys/mman.h> // NOLINT

(...skipping 76 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
87 break;	87 break;

88 case kReadOnly:	88 case kReadOnly:

89 prot = PROT_READ;	89 prot = PROT_READ;

90 break;	90 break;

91 case kReadWrite:	91 case kReadWrite:

92 prot = PROT_READ \| PROT_WRITE;	92 prot = PROT_READ \| PROT_WRITE;

93 break;	93 break;

94 case kReadExecute:	94 case kReadExecute:

95 prot = PROT_READ \| PROT_EXEC;	95 prot = PROT_READ \| PROT_EXEC;

96 break;	96 break;

	97 case kReadWriteExecute:

	98 prot = PROT_READ \| PROT_WRITE \| PROT_EXEC;

	99 break;

97 }	100 }

98 return (mprotect(reinterpret_cast<void*>(page_address),	101 return (mprotect(reinterpret_cast<void*>(page_address),

99 end_address - page_address,	102 end_address - page_address,

100 prot) == 0);	103 prot) == 0);

101 }	104 }

102	105

103 } // namespace dart	106 } // namespace dart

104	107

105 #endif // defined(TARGET_OS_ANDROID)	108 #endif // defined(TARGET_OS_ANDROID)

OLD	NEW

« no previous file with comments | « runtime/vm/virtual_memory.h ('k') | runtime/vm/virtual_memory_linux.cc » ('j') | no next file with comments »