runtime/vm/virtual_memory_win.cc - Issue 138913016: Fix flag to switch write protection of code pages on/off.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/vm/virtual_memory_win.cc

Issue 138913016: Fix flag to switch write protection of code pages on/off. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: fixed test to match expectation Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 #include "vm/globals.h"	5 #include "vm/globals.h"

6 #if defined(TARGET_OS_WINDOWS)	6 #if defined(TARGET_OS_WINDOWS)

7	7

8 #include "vm/virtual_memory.h"	8 #include "vm/virtual_memory.h"

9	9

10 #include "platform/assert.h"	10 #include "platform/assert.h"

(...skipping 64 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
75 break;	75 break;

76 case kReadOnly:	76 case kReadOnly:

77 prot = PAGE_READONLY;	77 prot = PAGE_READONLY;

78 break;	78 break;

79 case kReadWrite:	79 case kReadWrite:

80 prot = PAGE_READWRITE;	80 prot = PAGE_READWRITE;

81 break;	81 break;

82 case kReadExecute:	82 case kReadExecute:

83 prot = PAGE_EXECUTE_READ;	83 prot = PAGE_EXECUTE_READ;

84 break;	84 break;

	85 case kReadWriteExecute:

	86 prot = PAGE_EXECUTE_READWRITE;

	87 break;

85 }	88 }

86 DWORD old_prot = 0;	89 DWORD old_prot = 0;

87 bool result = VirtualProtect(reinterpret_cast<void*>(page_address),	90 bool result = VirtualProtect(reinterpret_cast<void*>(page_address),

88 end_address - page_address,	91 end_address - page_address,

89 prot,	92 prot,

90 &old_prot);	93 &old_prot);

91 return result;	94 return result;

92 }	95 }

93	96

94 } // namespace dart	97 } // namespace dart

95	98

96 #endif // defined(TARGET_OS_WINDOWS)	99 #endif // defined(TARGET_OS_WINDOWS)

OLD	NEW

« no previous file with comments | « runtime/vm/virtual_memory_macos.cc ('k') | no next file » | no next file with comments »