Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1383573002: VM: More compact code for pushing constant arguments on ia32/x64. (Closed)

Created:
5 years, 2 months ago by Florian Schneider
Modified:
5 years, 2 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: More compact code for pushing constant arguments on ia32/x64. Generate push imm8/imm32 instead of mov reg, imm32 push reg R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/a979c07e0370039ae9dff86cb1e98f810e9bdd34

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -10 lines) Patch
M runtime/vm/assembler_ia32.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 chunk +5 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 1 chunk +7 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 1 chunk +7 lines, -3 lines 0 comments Download
M runtime/vm/locations.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Florian Schneider
5 years, 2 months ago (2015-09-30 14:24:36 UTC) #2
srdjan
lgtm https://codereview.chromium.org/1383573002/diff/1/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://codereview.chromium.org/1383573002/diff/1/runtime/vm/intermediate_language_ia32.cc#newcode166 runtime/vm/intermediate_language_ia32.cc:166: } Maybe: else { ASSERT(locs()->out(0).IsInvalid()) or constant ...
5 years, 2 months ago (2015-09-30 17:00:20 UTC) #3
Florian Schneider
Committed patchset #2 (id:20001) manually as a979c07e0370039ae9dff86cb1e98f810e9bdd34 (presubmit successful).
5 years, 2 months ago (2015-10-01 09:16:22 UTC) #4
Florian Schneider
5 years, 2 months ago (2015-10-01 09:16:31 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1383573002/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/1383573002/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language_ia32.cc:166: }
On 2015/09/30 17:00:20, srdjan wrote:
> Maybe:
> 
> else {
>   ASSERT(locs()->out(0).IsInvalid()) or constant ...
> }
> 
> or similar

Done.

Powered by Google App Engine
This is Rietveld 408576698