Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Side by Side Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 1383573002: VM: More compact code for pushing constant arguments on ia32/x64. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: addressed comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 733 matching lines...) Expand 10 before | Expand all | Expand 10 after
744 744
745 void FlowGraphCompiler::EmitInstructionEpilogue(Instruction* instr) { 745 void FlowGraphCompiler::EmitInstructionEpilogue(Instruction* instr) {
746 if (is_optimizing()) { 746 if (is_optimizing()) {
747 return; 747 return;
748 } 748 }
749 Definition* defn = instr->AsDefinition(); 749 Definition* defn = instr->AsDefinition();
750 if ((defn != NULL) && defn->HasTemp()) { 750 if ((defn != NULL) && defn->HasTemp()) {
751 Location value = defn->locs()->out(0); 751 Location value = defn->locs()->out(0);
752 if (value.IsRegister()) { 752 if (value.IsRegister()) {
753 __ pushl(value.reg()); 753 __ pushl(value.reg());
754 } else if (value.IsConstant()) {
755 __ PushObject(value.constant());
754 } else { 756 } else {
755 ASSERT(value.IsStackSlot()); 757 ASSERT(value.IsStackSlot());
756 __ pushl(value.ToStackSlotAddress()); 758 __ pushl(value.ToStackSlotAddress());
757 } 759 }
758 } 760 }
759 } 761 }
760 762
761 763
762 void FlowGraphCompiler::CopyParameters() { 764 void FlowGraphCompiler::CopyParameters() {
763 __ Comment("Copy parameters"); 765 __ Comment("Copy parameters");
(...skipping 1061 matching lines...) Expand 10 before | Expand all | Expand 10 after
1825 __ movups(reg, Address(ESP, 0)); 1827 __ movups(reg, Address(ESP, 0));
1826 __ addl(ESP, Immediate(kFpuRegisterSize)); 1828 __ addl(ESP, Immediate(kFpuRegisterSize));
1827 } 1829 }
1828 1830
1829 1831
1830 #undef __ 1832 #undef __
1831 1833
1832 } // namespace dart 1834 } // namespace dart
1833 1835
1834 #endif // defined TARGET_ARCH_IA32 1836 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698