runtime/vm/flow_graph_compiler_ia32.cc - Issue 1383573002: VM: More compact code for pushing constant arguments on ia32/x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 1383573002: VM: More compact code for pushing constant arguments on ia32/x64. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: addressed comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_ia32.cc

diff --git a/runtime/vm/flow_graph_compiler_ia32.cc b/runtime/vm/flow_graph_compiler_ia32.cc

index 385a30cb4bf324eca621d40d3d5dbcade5c08091..2c7b3353684aa2703dcde1aa8f294c78153a4184 100644

--- a/runtime/vm/flow_graph_compiler_ia32.cc

+++ b/runtime/vm/flow_graph_compiler_ia32.cc

@@ -751,6 +751,8 @@ void FlowGraphCompiler::EmitInstructionEpilogue(Instruction* instr) {

Location value = defn->locs()->out(0);

if (value.IsRegister()) {

__ pushl(value.reg());

+ } else if (value.IsConstant()) {

+ __ PushObject(value.constant());

} else {

ASSERT(value.IsStackSlot());

__ pushl(value.ToStackSlotAddress());

« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »