Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1383503002: Add Resolution and Parsing interfaces for computeType, ensureResolved and parseNode. (Closed)

Created:
5 years, 2 months ago by Johnni Winther
Modified:
5 years, 2 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add Resolution and Parsing interfaces for computeType, ensureResolved and parseNode. BUG= R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/d25224c2120f2df6cc5ce753b1eed3201896fd26

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add TODOs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+737 lines, -560 lines) Patch
M pkg/compiler/lib/src/closure.dart View 6 chunks +8 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 1 3 chunks +34 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 4 chunks +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 16 chunks +105 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/constant_system_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 4 chunks +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/dart_types.dart View 18 chunks +24 lines, -22 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 4 chunks +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 6 chunks +7 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 34 chunks +79 lines, -77 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 11 chunks +15 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 21 chunks +32 lines, -30 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_system_javascript.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/patch_resolver.dart View 4 chunks +11 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/type_test_registry.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/mirrors_used.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 13 chunks +38 lines, -36 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 7 chunks +8 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/native/native.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/native/ssa.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/parser_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/partial_elements.dart View 10 chunks +48 lines, -44 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 13 chunks +17 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_members.dart View 5 chunks +8 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 3 chunks +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 20 chunks +24 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 25 chunks +37 lines, -31 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_common.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 4 chunks +7 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/typedefs.dart View 7 chunks +11 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 6 chunks +8 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 5 chunks +7 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 21 chunks +27 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 2 chunks +3 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/call_site_simple_type_inferer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/compiler_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/concrete_type_inference_test.dart View 4 chunks +12 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/find_my_name_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/least_upper_bound_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/metadata_test.dart View 5 chunks +9 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/override_inheritance_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/parser_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 15 chunks +17 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 9 chunks +17 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 12 chunks +19 lines, -18 lines 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_equals_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/type_order_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/type_representation_test.dart View 3 chunks +13 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/type_substitution_test.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/type_test_helper.dart View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
Main changes in common/resolution.dart, parser/partial_elements.dart and compiler.dart
5 years, 2 months ago (2015-09-30 12:04:05 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1383503002/diff/1/pkg/compiler/lib/src/common/resolution.dart File pkg/compiler/lib/src/common/resolution.dart (right): https://codereview.chromium.org/1383503002/diff/1/pkg/compiler/lib/src/common/resolution.dart#newcode135 pkg/compiler/lib/src/common/resolution.dart:135: abstract class Resolution { Perhaps `Resolver` https://codereview.chromium.org/1383503002/diff/1/pkg/compiler/lib/src/common/resolution.dart#newcode148 pkg/compiler/lib/src/common/resolution.dart:148: ...
5 years, 2 months ago (2015-10-01 08:54:13 UTC) #3
Johnni Winther
https://codereview.chromium.org/1383503002/diff/1/pkg/compiler/lib/src/common/resolution.dart File pkg/compiler/lib/src/common/resolution.dart (right): https://codereview.chromium.org/1383503002/diff/1/pkg/compiler/lib/src/common/resolution.dart#newcode135 pkg/compiler/lib/src/common/resolution.dart:135: abstract class Resolution { On 2015/10/01 08:54:13, sigurdm wrote: ...
5 years, 2 months ago (2015-10-01 09:33:53 UTC) #4
Johnni Winther
5 years, 2 months ago (2015-10-01 09:40:56 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d25224c2120f2df6cc5ce753b1eed3201896fd26 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698