pkg/compiler/lib/src/js_emitter/type_test_registry.dart - Issue 1383503002: Add Resolution and Parsing interfaces for computeType, ensureResolved and parseNode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/type_test_registry.dart

Issue 1383503002: Add Resolution and Parsing interfaces for computeType, ensureResolved and parseNode. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Add TODOs. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart ('k') | pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/type_test_registry.dart

diff --git a/pkg/compiler/lib/src/js_emitter/type_test_registry.dart b/pkg/compiler/lib/src/js_emitter/type_test_registry.dart

index ac333cc2034c84f5fcd1f804b08c87b03c34d9d1..f329cbfea22fa711fc10346c26c3f9ffabcf72ce 100644

--- a/pkg/compiler/lib/src/js_emitter/type_test_registry.dart

+++ b/pkg/compiler/lib/src/js_emitter/type_test_registry.dart

@@ -129,7 +129,7 @@ class TypeTestRegistry {

backend.generatedCode.keys.where((element) {

return canBeReflectedAsFunction(element) && canBeReified(element);

}).forEach((FunctionElement function) {

- DartType type = function.computeType(compiler);

+ DartType type = function.type;

for (ClassElement cls in backend.rti.getReferencedClasses(type)) {

while (cls != null) {

rtiNeededClasses.add(cls);

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart ('k') | pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart » ('j') | no next file with comments »