pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart - Issue 1383503002: Add Resolution and Parsing interfaces for computeType, ensureResolved and parseNode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart

Issue 1383503002: Add Resolution and Parsing interfaces for computeType, ensureResolved and parseNode. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Add TODOs. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart

diff --git a/pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart b/pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart

index 38347282be46b5590d124fc448e8ab1be908150a..287afb98c8b3a57e8bdb92ebc99e829621ac515f 100644

--- a/pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart

+++ b/pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart

@@ -230,7 +230,7 @@ abstract class Dart2JsElementMirror extends Dart2JsDeclarationMirror {

for (MetadataAnnotation metadata in _element.metadata) {

_appendCommentTokens(

mirrorSystem.compiler.commentMap[metadata.beginToken]);

- metadata.ensureResolved(mirrorSystem.compiler);

+ metadata.ensureResolved(mirrorSystem.compiler.resolution);

_metadata.add(_convertConstantToInstanceMirror(

mirrorSystem, metadata.constant,

mirrorSystem.compiler.constants.getConstantValue(

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/type_test_registry.dart ('k') | pkg/compiler/lib/src/mirrors_used.dart » ('j') | no next file with comments »