Issue 13771010: Fix recursive directory-deletion of top-level files/links.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13771010: Fix recursive directory-deletion of top-level files/links. (Closed)

Created:
7 years, 8 months ago by Anders Johnsen

Modified:
7 years, 8 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix recursive directory-deletion of top-level files/links. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21060

Patch Set 1 #

Patch Set 2 : Actually do the right thing. #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -64 lines)			Patch
M	runtime/bin/directory_android.cc	View	1	2 chunks	+4 lines, -7 lines	0 comments	Download
M	runtime/bin/directory_linux.cc	View	1	2 chunks	+4 lines, -7 lines	0 comments	Download
M	runtime/bin/directory_macos.cc	View	1	2 chunks	+4 lines, -7 lines	0 comments	Download
M	runtime/bin/directory_win.cc	View	1	1 chunk	+11 lines, -9 lines	0 comments	Download
M	tests/standalone/io/directory_error_test.dart	View	1	1 chunk	+2 lines, -7 lines	0 comments	Download
M	tests/standalone/io/file_system_delete_test.dart	View	1	6 chunks	+34 lines, -21 lines	0 comments	Download
M	utils/pub/io.dart	View		1 chunk	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Committed patchset #2 manually as r21060 (presubmit successful).

7 years, 8 months ago (2013-04-08 11:31:10 UTC) #3

nweiz

7 years, 8 months ago (2013-04-10 23:17:01 UTC) #4

Message was sent while issue was closed.

On 2013/04/08 11:31:10, Anders Johnsen wrote:
> Committed patchset #2 manually as r21060 (presubmit successful).

Please CC Bob and myself on CLs that change code we own.

Expand Messages | Collapse Messages