Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: tests/standalone/io/directory_error_test.dart

Issue 13771010: Fix recursive directory-deletion of top-level files/links. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Actually do the right thing. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/directory_win.cc ('k') | tests/standalone/io/file_system_delete_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/directory_error_test.dart
diff --git a/tests/standalone/io/directory_error_test.dart b/tests/standalone/io/directory_error_test.dart
index 2d1c0b7ea429ca9fd8dc9d7012ed0f7a14c7ef0f..33418ef175499c719f9689fc2ce07b348256a81a 100644
--- a/tests/standalone/io/directory_error_test.dart
+++ b/tests/standalone/io/directory_error_test.dart
@@ -95,13 +95,8 @@ bool checkDeleteRecursivelyNonExistentFileException(e) {
Expect.isTrue(e is DirectoryIOException);
Expect.isTrue(e.osError != null);
Expect.isTrue(e.toString().indexOf("Deletion failed") != -1);
- if (Platform.operatingSystem == "linux") {
- Expect.equals(2, e.osError.errorCode);
- } else if (Platform.operatingSystem == "macos") {
- Expect.equals(2, e.osError.errorCode);
- } else if (Platform.operatingSystem == "windows") {
- Expect.equals(3, e.osError.errorCode);
- }
+ // File not not found has error code 2 on all supported platforms.
+ Expect.equals(2, e.osError.errorCode);
return true;
}
« no previous file with comments | « runtime/bin/directory_win.cc ('k') | tests/standalone/io/file_system_delete_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698