Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: utils/pub/io.dart

Issue 13771010: Fix recursive directory-deletion of top-level files/links. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Actually do the right thing. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/file_system_delete_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/io.dart
diff --git a/utils/pub/io.dart b/utils/pub/io.dart
index 3eed22c0aa971b3a7e3c35dc7221df5348ebe2f2..0b6445b3d799470dd2ae780f4fa59bbd099e81ee 100644
--- a/utils/pub/io.dart
+++ b/utils/pub/io.dart
@@ -188,12 +188,7 @@ bool dirExists(String dir) => new Directory(dir).existsSync();
void deleteEntry(String path) {
if (linkExists(path)) {
log.io("Deleting link $path.");
- if (Platform.operatingSystem == 'windows') {
- // TODO(nweiz): remove this when issue 9278 is fixed.
- new Directory(path).deleteSync();
- } else {
- new Link(path).deleteSync();
- }
+ new Link(path).deleteSync();
} else if (dirExists(path)) {
log.io("Deleting directory $path.");
new Directory(path).deleteSync(recursive: true);
« no previous file with comments | « tests/standalone/io/file_system_delete_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698