Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1376963002: Cleanup: we are not patching entries any longer (Closed)

Created:
5 years, 2 months ago by srdjan
Modified:
5 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rename methods #

Patch Set 3 : More renaming #

Patch Set 4 : Cleanup #

Total comments: 6

Patch Set 5 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -78 lines) Patch
M runtime/vm/code_generator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_patcher.h View 1 chunk +0 lines, -9 lines 0 comments Download
M runtime/vm/code_patcher.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M runtime/vm/compiler.cc View 1 2 2 chunks +1 line, -12 lines 0 comments Download
M runtime/vm/instructions_ia32.h View 1 chunk +5 lines, -17 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 chunks +24 lines, -10 lines 0 comments Download
M runtime/vm/weak_code.cc View 1 2 3 4 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
srdjan
5 years, 2 months ago (2015-09-29 22:50:41 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/1376963002/diff/60001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1376963002/diff/60001/runtime/vm/object.cc#newcode13274 runtime/vm/object.cc:13274: ASSERT(instructions() == active_instructions()); ASSERT(IsFunctionCode()) https://codereview.chromium.org/1376963002/diff/60001/runtime/vm/object.cc#newcode13282 runtime/vm/object.cc:13282: ASSERT(instructions() == ...
5 years, 2 months ago (2015-09-29 23:30:57 UTC) #3
srdjan
https://codereview.chromium.org/1376963002/diff/60001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1376963002/diff/60001/runtime/vm/object.cc#newcode13274 runtime/vm/object.cc:13274: ASSERT(instructions() == active_instructions()); On 2015/09/29 23:30:57, rmacnak wrote: > ...
5 years, 2 months ago (2015-09-30 16:36:18 UTC) #4
srdjan
5 years, 2 months ago (2015-09-30 17:23:09 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
edccf3af0ae02a8f841d830893d9bcd4319497cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698