Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2754)

Unified Diff: runtime/vm/weak_code.cc

Issue 1376963002: Cleanup: we are not patching entries any longer (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Address review comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/weak_code.cc
diff --git a/runtime/vm/weak_code.cc b/runtime/vm/weak_code.cc
index 85e623afb9c1b7d138e40c017bb8244be728275f..cf1e132c5f4035fc096d50d8b2917380a54deec7 100644
--- a/runtime/vm/weak_code.cc
+++ b/runtime/vm/weak_code.cc
@@ -115,17 +115,15 @@ void WeakCodeReferences::DisableCode() {
// function is invoked, it will be compiled again.
function.ClearCode();
// Invalidate the old code object so existing references to it
- // (from optimized code) will fail when invoked.
- if (!CodePatcher::IsEntryPatched(code)) {
- CodePatcher::PatchEntry(
- code, Code::Handle(StubCode::FixCallersTarget_entry()->code()));
+ // (from optimized code) will be patched when invoked.
+ if (!code.IsDisabled()) {
+ code.DisableDartCode();
}
} else {
// Make non-OSR code non-entrant.
- if (!CodePatcher::IsEntryPatched(code)) {
+ if (!code.IsDisabled()) {
ReportSwitchingCode(code);
- CodePatcher::PatchEntry(
- code, Code::Handle(StubCode::FixCallersTarget_entry()->code()));
+ code.DisableDartCode();
}
}
}
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698