runtime/vm/code_generator.cc - Issue 1376963002: Cleanup: we are not patching entries any longer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_generator.cc

Issue 1376963002: Cleanup: we are not patching entries any longer (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Address review comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/code_generator.cc

diff --git a/runtime/vm/code_generator.cc b/runtime/vm/code_generator.cc

index f844cea3fb3d67f9f22daf7397b68a000f125181..030678cbf6185c487530516b7e7d51da71664e11 100644

--- a/runtime/vm/code_generator.cc

+++ b/runtime/vm/code_generator.cc

@@ -1542,7 +1542,7 @@ DEFINE_RUNTIME_ENTRY(FixAllocationStubTarget, 0) {

Code& alloc_stub = Code::Handle(isolate, alloc_class.allocation_stub());

if (alloc_stub.IsNull()) {

alloc_stub = StubCode::GetAllocationStubForClass(alloc_class);

- ASSERT(!CodePatcher::IsEntryPatched(alloc_stub));

+ ASSERT(!alloc_stub.IsDisabled());

}

CodePatcher::PatchStaticCallAt(frame->pc(),

caller_code,

« no previous file with comments | « no previous file | runtime/vm/code_patcher.h » ('j') | no next file with comments »