Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1375343002: Remove obsolete timer list from VM (Closed)

Created:
5 years, 2 months ago by hausner
Modified:
5 years, 2 months ago
Reviewers:
turnidge, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, Ivan Posva, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove obsolete timer list from VM The functionality is now covered with TimeLine and CompilerStats BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/4995b84051871191168d8cce438f45b64211288a

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -153 lines) Patch
M runtime/observatory/lib/src/service/object.dart View 2 chunks +0 lines, -15 lines 0 comments Download
M runtime/vm/compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/dart.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 10 chunks +0 lines, -12 lines 0 comments Download
M runtime/vm/heap.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/isolate.h View 2 chunks +0 lines, -3 lines 0 comments Download
M runtime/vm/isolate.cc View 4 chunks +0 lines, -9 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/parser.cc View 3 chunks +3 lines, -13 lines 0 comments Download
M runtime/vm/timer.h View 2 chunks +0 lines, -50 lines 5 comments Download
M runtime/vm/timer.cc View 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
hausner
Todd can you please look at the changes in object.dart. Thank you.
5 years, 2 months ago (2015-09-30 18:16:21 UTC) #2
Cutch
https://codereview.chromium.org/1375343002/diff/1/runtime/vm/timer.h File runtime/vm/timer.h (right): https://codereview.chromium.org/1375343002/diff/1/runtime/vm/timer.h#newcode18 runtime/vm/timer.h:18: class Timer : public ValueObject { Why isn't this ...
5 years, 2 months ago (2015-09-30 18:19:26 UTC) #3
hausner
https://codereview.chromium.org/1375343002/diff/1/runtime/vm/timer.h File runtime/vm/timer.h (right): https://codereview.chromium.org/1375343002/diff/1/runtime/vm/timer.h#newcode18 runtime/vm/timer.h:18: class Timer : public ValueObject { On 2015/09/30 18:19:26, ...
5 years, 2 months ago (2015-09-30 18:25:50 UTC) #4
Cutch
lgtm
5 years, 2 months ago (2015-09-30 18:27:28 UTC) #5
hausner
5 years, 2 months ago (2015-09-30 19:48:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4995b84051871191168d8cce438f45b64211288a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698