Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Unified Diff: runtime/vm/timer.h

Issue 1375343002: Remove obsolete timer list from VM (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/parser.cc ('k') | runtime/vm/timer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/timer.h
diff --git a/runtime/vm/timer.h b/runtime/vm/timer.h
index 32af994e34054657fb76e38cdaa118a02b6a6e6a..4738efa50d539a09b9262571f7218edd8d3bdbb1 100644
--- a/runtime/vm/timer.h
+++ b/runtime/vm/timer.h
@@ -90,41 +90,6 @@ class Timer : public ValueObject {
DISALLOW_COPY_AND_ASSIGN(Timer);
};
-// List of per isolate timers.
-#define TIMER_LIST(V) \
- V(time_script_loading, "Script Loading") \
- V(time_creating_snapshot, "Snapshot Creation") \
- V(time_isolate_initialization, "Isolate initialization") \
- V(time_compilation, "Function compilation") \
- V(time_bootstrap, "Bootstrap of core classes") \
- V(time_dart_execution, "Dart execution") \
- V(time_total_runtime, "Total runtime for isolate") \
- V(time_gc, "Garbage collection") \
-
-// Maintains a list of timers per isolate.
-class TimerList : public ValueObject {
- public:
- TimerList();
- ~TimerList() {}
-
- // Accessors.
-#define TIMER_FIELD_ACCESSOR(name, msg) \
- Timer& name() { return name##_; }
- TIMER_LIST(TIMER_FIELD_ACCESSOR)
-#undef TIMER_FIELD_ACCESSOR
-
- void ReportTimers();
-
- void PrintTimersToJSONProperty(JSONObject* jsobj);
-
- private:
-#define TIMER_FIELD(name, msg) Timer name##_;
- TIMER_LIST(TIMER_FIELD)
-#undef TIMER_FIELD
- bool padding_;
- DISALLOW_COPY_AND_ASSIGN(TimerList);
-};
-
// The class TimerScope is used to start and stop a timer within a scope.
// It is used as follows:
@@ -207,21 +172,6 @@ class PauseTimerScope : public StackResource {
};
-// Macros to deal with named timers in the isolate.
-#define START_TIMER(isolate, name) \
-isolate->timer_list().name().Start();
-
-#define STOP_TIMER(isolate, name) \
-isolate->timer_list().name().Stop();
-
-#define TIMERSCOPE(thread, name) \
- TimerScope vm_internal_timer_( \
- true, &(thread->isolate()->timer_list().name()), thread)
-
-#define PAUSETIMERSCOPE(thread, name) \
-PauseTimerScope vm_internal_timer_(true, \
- &(thread->isolate()->timer_list().name()), \
- thread)
} // namespace dart
« no previous file with comments | « runtime/vm/parser.cc ('k') | runtime/vm/timer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698