Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: runtime/vm/isolate.cc

Issue 1375343002: Remove obsolete timer list from VM (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index 9229d81de8a19b867baa2a289cfda45c3b02f751..ce4c102ad2babdb2f9d572a92bb944f7bf142da9 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -430,10 +430,6 @@ bool IsolateMessageHandler::HandleMessage(Message* message) {
tds.SetNumArguments(1);
tds.CopyArgument(0, "isolateName", I->name());
- // TODO(turnidge): Rework collection total dart execution. This can
- // overcount when other things (gc, compilation) are active.
- TIMERSCOPE(thread, time_dart_execution);
-
// If the message is in band we lookup the handler to dispatch to. If the
// receive port was closed, we drop the message without deserializing it.
// Illegal port is a special case for artificially enqueued isolate library
@@ -731,7 +727,6 @@ Isolate::Isolate(const Dart_IsolateFlags& api_flags)
flags_(),
random_(),
simulator_(NULL),
- timer_list_(),
deopt_id_(0),
mutex_(new Mutex()),
stack_limit_(0),
@@ -1596,9 +1591,6 @@ void Isolate::LowLevelShutdown() {
delete message_handler();
set_message_handler(NULL);
- // Dump all accumulated timer data for the isolate.
- timer_list_.ReportTimers();
-
// Before analyzing the isolate's timeline blocks- reclaim all cached blocks.
ReclaimTimelineBlocks();
@@ -1866,7 +1858,6 @@ void Isolate::PrintJSON(JSONStream* stream, bool ref) {
jsobj.AddProperty("rootLib", lib);
}
- timer_list().PrintTimersToJSONProperty(&jsobj);
{
JSONObject tagCounters(&jsobj, "_tagCounters");
vm_tag_counters()->PrintToJSONObject(&tagCounters);
« no previous file with comments | « runtime/vm/isolate.h ('k') | runtime/vm/object.cc » ('j') | runtime/vm/timer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698