Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1374243002: Remove Registry arguments from Enqueuer. (Closed)

Created:
5 years, 2 months ago by Johnni Winther
Modified:
5 years, 2 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -82 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 1 2 chunks +14 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 10 chunks +24 lines, -29 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 6 chunks +17 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 2 chunks +14 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 5 chunks +8 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 2 months ago (2015-09-29 13:00:45 UTC) #2
sigurdm
lgtm https://codereview.chromium.org/1374243002/diff/1/pkg/compiler/lib/src/common/backend_api.dart File pkg/compiler/lib/src/common/backend_api.dart (right): https://codereview.chromium.org/1374243002/diff/1/pkg/compiler/lib/src/common/backend_api.dart#newcode163 pkg/compiler/lib/src/common/backend_api.dart:163: /// instantiated. This comment is outdated cf. our ...
5 years, 2 months ago (2015-09-29 14:37:09 UTC) #3
Johnni Winther
https://codereview.chromium.org/1374243002/diff/1/pkg/compiler/lib/src/common/backend_api.dart File pkg/compiler/lib/src/common/backend_api.dart (right): https://codereview.chromium.org/1374243002/diff/1/pkg/compiler/lib/src/common/backend_api.dart#newcode163 pkg/compiler/lib/src/common/backend_api.dart:163: /// instantiated. On 2015/09/29 14:37:09, sigurdm wrote: > This ...
5 years, 2 months ago (2015-09-30 08:00:57 UTC) #4
Johnni Winther
5 years, 2 months ago (2015-09-30 08:06:59 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
86c76de23799153bf91ed32ed53be86816fc1cc9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698