Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 1374243002: Remove Registry arguments from Enqueuer. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comment. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/enqueue.dart ('k') | pkg/compiler/lib/src/js_backend/type_variable_handler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart
index 430dc7465af90e859e13f03d800885a21a6fd7b1..ff254c9d16a06f3ac73183223177f15177a139dd 100644
--- a/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/pkg/compiler/lib/src/js_backend/backend.dart
@@ -1171,8 +1171,13 @@ class JavaScriptBackend extends Backend {
}
}
- void registerInstantiatedType(InterfaceType type, Registry registry) {
+ void registerInstantiatedType(InterfaceType type,
+ Enqueuer enqueuer,
+ Registry registry,
+ {bool mirrorUsage: false}) {
lookupMapAnalysis.registerInstantiatedType(type, registry);
+ super.registerInstantiatedType(
+ type, enqueuer, registry, mirrorUsage: mirrorUsage);
}
void registerUseInterceptor(Enqueuer enqueuer) {
@@ -1247,6 +1252,7 @@ class JavaScriptBackend extends Backend {
if (enqueuer.isResolutionQueue || methodNeedsRti(closure)) {
registerComputeSignature(enqueuer, registry);
}
+ super.registerClosureWithFreeTypeVariables(closure, enqueuer, registry);
}
/// Call during codegen if an instance of [closure] is being created.
@@ -1259,16 +1265,19 @@ class JavaScriptBackend extends Backend {
void registerBoundClosure(Enqueuer enqueuer) {
boundClosureClass.ensureResolved(compiler);
- enqueuer.registerInstantiatedType(
+ registerInstantiatedType(
boundClosureClass.rawType,
+ enqueuer,
// Precise dependency is not important here.
compiler.globalDependencies);
}
void registerGetOfStaticFunction(Enqueuer enqueuer) {
closureClass.ensureResolved(compiler);
- enqueuer.registerInstantiatedType(
- closureClass.rawType, compiler.globalDependencies);
+ registerInstantiatedType(
+ closureClass.rawType,
+ enqueuer,
+ compiler.globalDependencies);
}
void registerComputeSignature(Enqueuer enqueuer, Registry registry) {
@@ -1454,7 +1463,7 @@ class JavaScriptBackend extends Backend {
helpersUsed.add(cls.implementation);
}
cls.ensureResolved(compiler);
- enqueuer.registerInstantiatedType(cls.rawType, registry);
+ registerInstantiatedType(cls.rawType, enqueuer, registry);
}
WorldImpact codegen(CodegenWorkItem work) {
@@ -2759,7 +2768,7 @@ class JavaScriptBackend extends Backend {
} else if (element.asyncMarker == AsyncMarker.SYNC_STAR) {
ClassElement clsSyncStarIterable = getSyncStarIterable();
clsSyncStarIterable.ensureResolved(compiler);
- enqueuer.registerInstantiatedType(clsSyncStarIterable.rawType, registry);
+ registerInstantiatedType(clsSyncStarIterable.rawType, enqueuer, registry);
enqueue(enqueuer, getSyncStarIterableConstructor(), registry);
enqueue(enqueuer, getEndOfIteration(), registry);
enqueue(enqueuer, getYieldStar(), registry);
@@ -2767,8 +2776,8 @@ class JavaScriptBackend extends Backend {
} else if (element.asyncMarker == AsyncMarker.ASYNC_STAR) {
ClassElement clsASyncStarController = getASyncStarController();
clsASyncStarController.ensureResolved(compiler);
- enqueuer.registerInstantiatedType(
- clsASyncStarController.rawType, registry);
+ registerInstantiatedType(
+ clsASyncStarController.rawType, enqueuer, registry);
enqueue(enqueuer, getAsyncStarHelper(), registry);
enqueue(enqueuer, getStreamOfController(), registry);
enqueue(enqueuer, getYieldSingle(), registry);
« no previous file with comments | « pkg/compiler/lib/src/enqueue.dart ('k') | pkg/compiler/lib/src/js_backend/type_variable_handler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698