Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: pkg/compiler/lib/src/resolution/registry.dart

Issue 1374243002: Remove Registry arguments from Enqueuer. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comment. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/native/enqueue.dart ('k') | tests/compiler/dart2js/type_combination_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/registry.dart
diff --git a/pkg/compiler/lib/src/resolution/registry.dart b/pkg/compiler/lib/src/resolution/registry.dart
index 47e5748766d608a6193526ac247775593e18da55..de12ef01a2723388b05da8eb3da556ac20eb049b 100644
--- a/pkg/compiler/lib/src/resolution/registry.dart
+++ b/pkg/compiler/lib/src/resolution/registry.dart
@@ -85,8 +85,7 @@ class EagerRegistry implements Registry {
@override
void registerInstantiation(InterfaceType type) {
- // TODO(johnniwinther): Remove the need for passing `this`.
- world.registerInstantiatedType(type, this);
+ world.registerInstantiatedType(type);
}
@override
@@ -448,7 +447,10 @@ class ResolutionRegistry implements Registry {
}
void registerClosure(LocalFunctionElement element) {
- world.registerClosure(element, this);
+ if (element.computeType(compiler).containsTypeVariables) {
+ backend.registerClosureWithFreeTypeVariables(element, world, this);
+ }
+ world.registerClosure(element);
}
void registerSuperUse(Node node) {
@@ -470,7 +472,7 @@ class ResolutionRegistry implements Registry {
void registerTypeLiteral(Send node, DartType type) {
mapping.setType(node, type);
backend.resolutionCallbacks.onTypeLiteral(type, this);
- world.registerInstantiatedType(compiler.coreTypes.typeType, this);
+ backend.registerInstantiatedType(compiler.coreTypes.typeType, world, this);
}
void registerMapLiteral(Node node, DartType type, bool isConstant) {
@@ -519,7 +521,7 @@ class ResolutionRegistry implements Registry {
}
void registerInstantiatedType(InterfaceType type) {
- world.registerInstantiatedType(type, this);
+ backend.registerInstantiatedType(type, world, this);
mapping.addRequiredType(type);
}
@@ -584,7 +586,7 @@ class ResolutionRegistry implements Registry {
}
void registerInstantiation(InterfaceType type) {
- world.registerInstantiatedType(type, this);
+ backend.registerInstantiatedType(type, world, this);
}
void registerAssert(bool hasMessage) {
« no previous file with comments | « pkg/compiler/lib/src/native/enqueue.dart ('k') | tests/compiler/dart2js/type_combination_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698