Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1373903004: Bootloader initialization cleanup. (Closed)

Created:
5 years, 2 months ago by pquitslund
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/analyzer_cli.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Bootloader initialization cleanup. Moves plugin config processing out of a plugin and inline. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/analyzer_cli/commit/a283261fc0d90c296e386b6ffad6759cab278ae7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -123 lines) Patch
M lib/src/bootloader.dart View 4 chunks +5 lines, -23 lines 0 comments Download
M lib/src/driver.dart View 6 chunks +0 lines, -31 lines 0 comments Download
D lib/src/plugin/plugin_config_processor_plugin.dart View 1 chunk +0 lines, -36 lines 0 comments Download
M test/driver_test.dart View 3 chunks +36 lines, -33 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
5 years, 2 months ago (2015-09-28 21:13:21 UTC) #2
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-09-28 21:26:28 UTC) #3
pquitslund
5 years, 2 months ago (2015-09-28 21:32:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a283261fc0d90c296e386b6ffad6759cab278ae7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698