Bootloader initialization cleanup.

lib/src/bootloader.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer_cli.src.bootloader;
 
 import 'dart:io';
 import 'dart:isolate';
 
 import 'package:analyzer/file_system/physical_file_system.dart';
-import 'package:analyzer/plugin/options.dart';
 import 'package:analyzer/source/analysis_options_provider.dart';
-import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/plugin/plugin_configuration.dart';
 import 'package:analyzer_cli/src/driver.dart';
 import 'package:analyzer_cli/src/options.dart';
-import 'package:analyzer_cli/src/plugin/plugin_config_processor_plugin.dart';
-import 'package:plugin/manager.dart';
-import 'package:plugin/plugin.dart';
 import 'package:source_span/source_span.dart';
 import 'package:yaml/src/yaml_node.dart';
 
 const _analyzerPackageName = 'analyzer';
 
 /// Source code assembler.
 class Assembler {
   /// Plugin configuration info.
   final PluginConfig _config;
 
@@ skipping 49 matching lines @@
         details += ' (line ${location.line}, column ${location.column})';
       }
     } else {
       details = e.toString();
     }
 
     errorSink.writeln('Plugin configuration skipped: $details');
   };
 
   /// Reads plugin config info from `.analysis_options`.
-  PluginConfigProcessorPlugin _pluginConfigProcessorPlugin =
-      new PluginConfigProcessorPlugin(_pluginConfigErrorHandler);
+  PluginConfigOptionsProcessor _pluginOptionsProcessor =
+      new PluginConfigOptionsProcessor(_pluginConfigErrorHandler);
 
   /// Create a loadable analyzer image configured with plugins derived from
   /// the given analyzer command-line `args`.
   Image createImage(List<String> args) {
-    _processPlugins();
-
     // Parse commandline options.
     CommandLineOptions options = CommandLineOptions.parse(args);
 
     // Process analysis options file (and notify all interested parties).
     _processAnalysisOptions(options);
 
     // TODO(pquitslund): Pass in .packages info
-    return new Image(_pluginConfigProcessorPlugin.pluginConfig,
+    return new Image(_pluginOptionsProcessor.config,
         args: args, packageRootPath: options.packageRootPath);
   }
 
   void _processAnalysisOptions(CommandLineOptions options) {
     // Determine options file path.
     var filePath = options.analysisOptionsFile != null
         ? options.analysisOptionsFile
         : AnalysisOptionsProvider.ANALYSIS_OPTIONS_NAME;
-    List<OptionsProcessor> optionsProcessors =
-        AnalysisEngine.instance.optionsPlugin.optionsProcessors;
     try {
       var file = PhysicalResourceProvider.INSTANCE.getFile(filePath);
       AnalysisOptionsProvider analysisOptionsProvider =
           new AnalysisOptionsProvider();
       Map<String, YamlNode> options =
           analysisOptionsProvider.getOptionsFromFile(file);
-      optionsProcessors
-          .forEach((OptionsProcessor p) => p.optionsProcessed(options));
+      _pluginOptionsProcessor.optionsProcessed(options);
     } on Exception catch (e) {
-      optionsProcessors.forEach((OptionsProcessor p) => p.onError(e));
+      _pluginOptionsProcessor.onError(e);
     }
   }
-
-  void _processPlugins() {
-    List<Plugin> plugins = <Plugin>[];
-    plugins.add(_pluginConfigProcessorPlugin);
-    plugins.addAll(AnalysisEngine.instance.supportedPlugins);
-    ExtensionManager manager = new ExtensionManager();
-    manager.processPlugins(plugins);
-  }
 }
 
 /// A loadable "image" of a a configured analyzer instance.
 class Image {
   /// (Optional) package root path.
   final String packageRootPath;
 
   /// (Optional) package map.
   final Map<String, Uri> packages;
 
@@ skipping 39 matching lines @@
     // TODO(pquitslund): add .packages support once the VM implements it.
     Isolate.spawnUri(uri, args, null /* msg */,
         packageRoot: packageUri,
         onError: errorListener.sendPort,
         onExit: exitListener.sendPort);
 
     // TODO(pquitslund): consider starting paused
     // http://stackoverflow.com/questions/29247374/what-is-the-best-way-to-track-the-state-of-an-isolate-in-dart
   }
 }