Bootloader initialization cleanup.

lib/src/driver.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer_cli.src.driver;
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 
 import 'package:analyzer/file_system/file_system.dart' as fileSystem;
 import 'package:analyzer/file_system/physical_file_system.dart';
 import 'package:analyzer/plugin/options.dart';
 import 'package:analyzer/source/analysis_options_provider.dart';
 import 'package:analyzer/source/package_map_provider.dart';
 import 'package:analyzer/source/package_map_resolver.dart';
 import 'package:analyzer/source/pub_package_map_provider.dart';
 import 'package:analyzer/source/sdk_ext.dart';
 import 'package:analyzer/src/generated/constant.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/error.dart';
 import 'package:analyzer/src/generated/interner.dart';
 import 'package:analyzer/src/generated/java_engine.dart';
 import 'package:analyzer/src/generated/java_io.dart';
 import 'package:analyzer/src/generated/sdk_io.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/generated/source_io.dart';
-import 'package:analyzer/src/plugin/plugin_configuration.dart';
 import 'package:analyzer_cli/src/analyzer_impl.dart';
 import 'package:analyzer_cli/src/options.dart';
-import 'package:analyzer_cli/src/plugin/plugin_config_processor_plugin.dart';
 import 'package:dev_compiler/strong_mode.dart';
 import 'package:linter/src/plugin/linter_plugin.dart';
 import 'package:package_config/discovery.dart' as pkgDiscovery;
 import 'package:package_config/packages.dart' show Packages;
 import 'package:package_config/packages_file.dart' as pkgfile show parse;
 import 'package:package_config/src/packages_impl.dart' show MapPackages;
 import 'package:path/path.dart' as path;
 import 'package:plugin/manager.dart';
 import 'package:plugin/plugin.dart';
-import 'package:source_span/source_span.dart';
 import 'package:yaml/yaml.dart';
 
 /// The maximum number of sources for which AST structures should be kept in the cache.
 const int _maxCacheSize = 512;
 
 /// Shared IO sink for standard error reporting.
 ///
 /// *Visible for testing.*
 StringSink errorSink = stderr;
 
 /// Shared IO sink for standard out reporting.
 ///
 /// *Visible for testing.*
 StringSink outSink = stdout;
 
 typedef ErrorSeverity _BatchRunnerHandler(List<String> args);
 
 class Driver {
-  /// Emits an error message to [errorSink] if plugin config can't be read.
-  static final ErrorHandler _pluginConfigErrorHandler = (Exception e) {
-    String details;
-    if (e is PluginConfigFormatException) {
-      details = e.message;
-      var node = e.yamlNode;
-      if (node is YamlNode) {
-        SourceLocation location = node.span.start;
-        details += ' (line ${location.line}, column ${location.column})';
-      }
-    } else {
-      details = e.toString();
-    }
-
-    errorSink.writeln('Plugin configuration skipped: $details');
-  };
-
   /// The plugins that are defined outside the `analyzer_cli` package.
   List<Plugin> _userDefinedPlugins = <Plugin>[];
 
   /// Indicates whether the analyzer is running in batch mode.
   bool _isBatch;
 
   /// The context that was most recently created by a call to [_analyzeAll], or
   /// `null` if [_analyzeAll] hasn't been called yet.
   AnalysisContext _context;
 
-  /// Reads plugin config info from `.analysis_options`.
-  PluginConfigProcessorPlugin _pluginConfigProcessorPlugin;
-
   /// The strong mode checker corresponding to [_context], or `null` if strong
   /// mode is not enabled or a context is not available yet.
   StrongChecker _strongChecker;
 
   /// If [_context] is not `null`, the [CommandLineOptions] that guided its
   /// creation.
   CommandLineOptions _previousOptions;
 
-  Driver()
-      : _pluginConfigProcessorPlugin =
-            new PluginConfigProcessorPlugin(_pluginConfigErrorHandler);
-
   /// This Driver's current analysis context.
   ///
   /// *Visible for testing.*
   AnalysisContext get context => _context;
 
-  /// Plugin configuration as processed from `.analysis_options`.
-  PluginConfig get pluginConfig => _pluginConfigProcessorPlugin.pluginConfig;
-
   /// Set the [plugins] that are defined outside the `analyzer_cli` package.
   void set userDefinedPlugins(List<Plugin> plugins) {
     _userDefinedPlugins = plugins == null ? <Plugin>[] : plugins;
   }
 
   /// Use the given command-line [args] to start this analysis driver.
   void start(List<String> args) {
     StringUtilities.INTERNER = new MappedInterner();
 
     _processPlugins();
@@ skipping 357 matching lines @@
           analysisOptionsProvider.getOptionsFromFile(file);
       optionsProcessors
           .forEach((OptionsProcessor p) => p.optionsProcessed(options));
     } on Exception catch (e) {
       optionsProcessors.forEach((OptionsProcessor p) => p.onError(e));
     }
   }
 
   void _processPlugins() {
     List<Plugin> plugins = <Plugin>[];
-    plugins.add(_pluginConfigProcessorPlugin);
     plugins.add(linterPlugin);
     plugins.addAll(AnalysisEngine.instance.supportedPlugins);
     plugins.addAll(_userDefinedPlugins);
     ExtensionManager manager = new ExtensionManager();
     manager.processPlugins(plugins);
   }
 
   /// Analyze a single source.
   ErrorSeverity _runAnalyzer(Source source, CommandLineOptions options) {
     int startTime = currentTimeMillis();
@@ skipping 119 matching lines @@
     for (var package in packages) {
       var packageName = path.basename(package.path);
       var realPath = package.resolveSymbolicLinksSync();
       result[packageName] = [
         PhysicalResourceProvider.INSTANCE.getFolder(realPath)
       ];
     }
     return result;
   }
 }