Issue 1357423005: Fail sooner and with better error message when attempting precompilation on IA32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1357423005: Fail sooner and with better error message when attempting precompilation on IA32. (Closed)

Created:
5 years, 3 months ago by rmacnak

Modified:
5 years, 3 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fail sooner and with better error message when attempting precompilation on IA32. Allocate megamorphic cache table in old space. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/c6d5e4796ec988cc856bee6d7bf813c1d3fb284a

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -5 lines)			Patch
M	runtime/bin/main.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/megamorphic_cache_table.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

rmacnak

5 years, 3 months ago (2015-09-23 20:47:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c6d5e4796ec988cc856bee6d7bf813c1d3fb284a (presubmit successful).