runtime/vm/flow_graph_compiler.cc - Issue 1357423005: Fail sooner and with better error message when attempting precompilation on IA32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 1357423005: Fail sooner and with better error message when attempting precompilation on IA32. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler.cc

diff --git a/runtime/vm/flow_graph_compiler.cc b/runtime/vm/flow_graph_compiler.cc

index 9616d6391a5e459f515adcefe26d4c848021c4d2..ca7627d8c581dd74ff9f9cd169b1c79d55a62d38 100644

--- a/runtime/vm/flow_graph_compiler.cc

+++ b/runtime/vm/flow_graph_compiler.cc

@@ -117,6 +117,10 @@ DECLARE_FLAG(bool, link_natives_lazily);

static void PrecompileModeHandler(bool value) {

if (value) {

+#if defined(TARGET_ARCH_IA32)

+ FATAL("Precompilation not supported on IA32");

+#endif

NooptModeHandler(true);

FLAG_lazy_dispatchers = false;

FLAG_interpret_irregexp = true;

« no previous file with comments | « runtime/bin/main.cc ('k') | runtime/vm/megamorphic_cache_table.cc » ('j') | no next file with comments »