Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Side by Side Diff: runtime/vm/flow_graph_compiler.cc

Issue 1357423005: Fail sooner and with better error message when attempting precompilation on IA32. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/bin/main.cc ('k') | runtime/vm/megamorphic_cache_table.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX.
6 6
7 #include "vm/flow_graph_compiler.h" 7 #include "vm/flow_graph_compiler.h"
8 8
9 #include "vm/bit_vector.h" 9 #include "vm/bit_vector.h"
10 #include "vm/cha.h" 10 #include "vm/cha.h"
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 "Run fast unoptimized code only."); 110 "Run fast unoptimized code only.");
111 111
112 112
113 DECLARE_FLAG(bool, lazy_dispatchers); 113 DECLARE_FLAG(bool, lazy_dispatchers);
114 DECLARE_FLAG(bool, interpret_irregexp); 114 DECLARE_FLAG(bool, interpret_irregexp);
115 DECLARE_FLAG(bool, enable_mirrors); 115 DECLARE_FLAG(bool, enable_mirrors);
116 DECLARE_FLAG(bool, link_natives_lazily); 116 DECLARE_FLAG(bool, link_natives_lazily);
117 117
118 static void PrecompileModeHandler(bool value) { 118 static void PrecompileModeHandler(bool value) {
119 if (value) { 119 if (value) {
120 #if defined(TARGET_ARCH_IA32)
121 FATAL("Precompilation not supported on IA32");
122 #endif
123
120 NooptModeHandler(true); 124 NooptModeHandler(true);
121 FLAG_lazy_dispatchers = false; 125 FLAG_lazy_dispatchers = false;
122 FLAG_interpret_irregexp = true; 126 FLAG_interpret_irregexp = true;
123 FLAG_enable_mirrors = false; 127 FLAG_enable_mirrors = false;
124 FLAG_precompile_collect_closures = true; 128 FLAG_precompile_collect_closures = true;
125 FLAG_link_natives_lazily = true; 129 FLAG_link_natives_lazily = true;
126 FLAG_fields_may_be_reset = true; 130 FLAG_fields_may_be_reset = true;
127 FLAG_allow_absolute_addresses = false; 131 FLAG_allow_absolute_addresses = false;
128 } 132 }
129 } 133 }
(...skipping 1703 matching lines...) Expand 10 before | Expand all | Expand 10 after
1833 1837
1834 1838
1835 void FlowGraphCompiler::FrameStateClear() { 1839 void FlowGraphCompiler::FrameStateClear() {
1836 ASSERT(!is_optimizing()); 1840 ASSERT(!is_optimizing());
1837 frame_state_.TruncateTo(0); 1841 frame_state_.TruncateTo(0);
1838 } 1842 }
1839 #endif 1843 #endif
1840 1844
1841 1845
1842 } // namespace dart 1846 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/bin/main.cc ('k') | runtime/vm/megamorphic_cache_table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698