Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 13516003: Fix the setters in _ByteDataView to behave the same as '[]=' and '[]' operators (Closed)

Created:
7 years, 8 months ago by siva
Modified:
7 years, 8 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, Florian Schneider
Visibility:
Public.

Description

Fix the setters in _ByteDataView to behave the same as '[]=' and '[]' operators in regular TypedData classes. Committed: https://code.google.com/p/dart/source/detail?r=20882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -9 lines) Patch
M runtime/lib/typeddata.dart View 8 chunks +8 lines, -8 lines 0 comments Download
M tests/standalone/typed_data_view_test.dart View 2 chunks +39 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
7 years, 8 months ago (2013-04-03 18:25:39 UTC) #1
srdjan
LGTM
7 years, 8 months ago (2013-04-03 18:27:55 UTC) #2
siva
7 years, 8 months ago (2013-04-03 18:52:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20882 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698