Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Side by Side Diff: runtime/lib/typeddata.dart

Issue 13516003: Fix the setters in _ByteDataView to behave the same as '[]=' and '[]' operators (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tests/standalone/typed_data_view_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 // patch classes for Int8List ..... Float64List and ByteData implementations. 5 // patch classes for Int8List ..... Float64List and ByteData implementations.
6 6
7 patch class Int8List { 7 patch class Int8List {
8 /* patch */ factory Int8List(int length) { 8 /* patch */ factory Int8List(int length) {
9 return new _Int8Array(length); 9 return new _Int8Array(length);
10 } 10 }
(...skipping 2850 matching lines...) Expand 10 before | Expand all | Expand 10 after
2861 int getInt8(int byteOffset) { 2861 int getInt8(int byteOffset) {
2862 if (byteOffset < 0 || byteOffset >= length) { 2862 if (byteOffset < 0 || byteOffset >= length) {
2863 _throwRangeError(byteOffset, length); 2863 _throwRangeError(byteOffset, length);
2864 } 2864 }
2865 return _typeddata._getInt8(_offset + byteOffset); 2865 return _typeddata._getInt8(_offset + byteOffset);
2866 } 2866 }
2867 void setInt8(int byteOffset, int value) { 2867 void setInt8(int byteOffset, int value) {
2868 if (byteOffset < 0 || byteOffset >= length) { 2868 if (byteOffset < 0 || byteOffset >= length) {
2869 _throwRangeError(byteOffset, length); 2869 _throwRangeError(byteOffset, length);
2870 } 2870 }
2871 _typeddata._setInt8(_offset + byteOffset, value); 2871 _typeddata._setInt8(_offset + byteOffset, _toInt8(value));
2872 } 2872 }
2873 2873
2874 int getUint8(int byteOffset) { 2874 int getUint8(int byteOffset) {
2875 if (byteOffset < 0 || byteOffset >= length) { 2875 if (byteOffset < 0 || byteOffset >= length) {
2876 _throwRangeError(byteOffset, length); 2876 _throwRangeError(byteOffset, length);
2877 } 2877 }
2878 return _typeddata._getUint8(_offset + byteOffset); 2878 return _typeddata._getUint8(_offset + byteOffset);
2879 } 2879 }
2880 void setUint8(int byteOffset, int value) { 2880 void setUint8(int byteOffset, int value) {
2881 if (byteOffset < 0 || byteOffset >= length) { 2881 if (byteOffset < 0 || byteOffset >= length) {
2882 _throwRangeError(byteOffset, length); 2882 _throwRangeError(byteOffset, length);
2883 } 2883 }
2884 _typeddata._setUint8(_offset + byteOffset, value); 2884 _typeddata._setUint8(_offset + byteOffset,_toUint8( value));
2885 } 2885 }
2886 2886
2887 int getInt16(int byteOffset) { 2887 int getInt16(int byteOffset) {
2888 if (byteOffset < 0 || byteOffset >= length) { 2888 if (byteOffset < 0 || byteOffset >= length) {
2889 _throwRangeError(byteOffset, length); 2889 _throwRangeError(byteOffset, length);
2890 } 2890 }
2891 return _typeddata._getInt16(_offset + byteOffset); 2891 return _typeddata._getInt16(_offset + byteOffset);
2892 } 2892 }
2893 void setInt16(int byteOffset, int value) { 2893 void setInt16(int byteOffset, int value) {
2894 if (byteOffset < 0 || byteOffset >= length) { 2894 if (byteOffset < 0 || byteOffset >= length) {
2895 _throwRangeError(byteOffset, length); 2895 _throwRangeError(byteOffset, length);
2896 } 2896 }
2897 _typeddata._setInt16(_offset + byteOffset, value); 2897 _typeddata._setInt16(_offset + byteOffset, _toInt16(value));
2898 } 2898 }
2899 2899
2900 int getUint16(int byteOffset) { 2900 int getUint16(int byteOffset) {
2901 if (byteOffset < 0 || byteOffset >= length) { 2901 if (byteOffset < 0 || byteOffset >= length) {
2902 _throwRangeError(byteOffset, length); 2902 _throwRangeError(byteOffset, length);
2903 } 2903 }
2904 return _typeddata._getUint16(_offset + byteOffset); 2904 return _typeddata._getUint16(_offset + byteOffset);
2905 } 2905 }
2906 void setUint16(int byteOffset, int value) { 2906 void setUint16(int byteOffset, int value) {
2907 if (byteOffset < 0 || byteOffset >= length) { 2907 if (byteOffset < 0 || byteOffset >= length) {
2908 _throwRangeError(byteOffset, length); 2908 _throwRangeError(byteOffset, length);
2909 } 2909 }
2910 _typeddata._setUint16(_offset + byteOffset, value); 2910 _typeddata._setUint16(_offset + byteOffset, _toUint16(value));
2911 } 2911 }
2912 2912
2913 int getInt32(int byteOffset) { 2913 int getInt32(int byteOffset) {
2914 if (byteOffset < 0 || byteOffset >= length) { 2914 if (byteOffset < 0 || byteOffset >= length) {
2915 _throwRangeError(byteOffset, length); 2915 _throwRangeError(byteOffset, length);
2916 } 2916 }
2917 return _typeddata._getInt32(_offset + byteOffset); 2917 return _typeddata._getInt32(_offset + byteOffset);
2918 } 2918 }
2919 void setInt32(int byteOffset, int value) { 2919 void setInt32(int byteOffset, int value) {
2920 if (byteOffset < 0 || byteOffset >= length) { 2920 if (byteOffset < 0 || byteOffset >= length) {
2921 _throwRangeError(byteOffset, length); 2921 _throwRangeError(byteOffset, length);
2922 } 2922 }
2923 _typeddata._setInt32(_offset + byteOffset, value); 2923 _typeddata._setInt32(_offset + byteOffset, _toInt32(value));
2924 } 2924 }
2925 2925
2926 int getUint32(int byteOffset) { 2926 int getUint32(int byteOffset) {
2927 if (byteOffset < 0 || byteOffset >= length) { 2927 if (byteOffset < 0 || byteOffset >= length) {
2928 _throwRangeError(byteOffset, length); 2928 _throwRangeError(byteOffset, length);
2929 } 2929 }
2930 return _typeddata._getUint32(_offset + byteOffset); 2930 return _typeddata._getUint32(_offset + byteOffset);
2931 } 2931 }
2932 void setUint32(int byteOffset, int value) { 2932 void setUint32(int byteOffset, int value) {
2933 if (byteOffset < 0 || byteOffset >= length) { 2933 if (byteOffset < 0 || byteOffset >= length) {
2934 _throwRangeError(byteOffset, length); 2934 _throwRangeError(byteOffset, length);
2935 } 2935 }
2936 _typeddata._setUint32(_offset + byteOffset, value); 2936 _typeddata._setUint32(_offset + byteOffset, _toUint32(value));
2937 } 2937 }
2938 2938
2939 int getInt64(int byteOffset) { 2939 int getInt64(int byteOffset) {
2940 if (byteOffset < 0 || byteOffset >= length) { 2940 if (byteOffset < 0 || byteOffset >= length) {
2941 _throwRangeError(byteOffset, length); 2941 _throwRangeError(byteOffset, length);
2942 } 2942 }
2943 return _typeddata._getInt64(_offset + byteOffset); 2943 return _typeddata._getInt64(_offset + byteOffset);
2944 } 2944 }
2945 void setInt64(int byteOffset, int value) { 2945 void setInt64(int byteOffset, int value) {
2946 if (byteOffset < 0 || byteOffset >= length) { 2946 if (byteOffset < 0 || byteOffset >= length) {
2947 _throwRangeError(byteOffset, length); 2947 _throwRangeError(byteOffset, length);
2948 } 2948 }
2949 _typeddata._setInt64(_offset + byteOffset, value); 2949 _typeddata._setInt64(_offset + byteOffset, _toInt64(value));
2950 } 2950 }
2951 2951
2952 int getUint64(int byteOffset) { 2952 int getUint64(int byteOffset) {
2953 if (byteOffset < 0 || byteOffset >= length) { 2953 if (byteOffset < 0 || byteOffset >= length) {
2954 _throwRangeError(byteOffset, length); 2954 _throwRangeError(byteOffset, length);
2955 } 2955 }
2956 return _typeddata._getUint64(_offset + byteOffset); 2956 return _typeddata._getUint64(_offset + byteOffset);
2957 } 2957 }
2958 void setUint64(int byteOffset, int value) { 2958 void setUint64(int byteOffset, int value) {
2959 if (byteOffset < 0 || byteOffset >= length) { 2959 if (byteOffset < 0 || byteOffset >= length) {
2960 _throwRangeError(byteOffset, length); 2960 _throwRangeError(byteOffset, length);
2961 } 2961 }
2962 _typeddata._setUint64(_offset + byteOffset, value); 2962 _typeddata._setUint64(_offset + byteOffset, _toUint64(value));
2963 } 2963 }
2964 2964
2965 double getFloat32(int byteOffset) { 2965 double getFloat32(int byteOffset) {
2966 if (byteOffset < 0 || byteOffset >= length) { 2966 if (byteOffset < 0 || byteOffset >= length) {
2967 _throwRangeError(byteOffset, length); 2967 _throwRangeError(byteOffset, length);
2968 } 2968 }
2969 return _typeddata._getFloat32(_offset + byteOffset); 2969 return _typeddata._getFloat32(_offset + byteOffset);
2970 } 2970 }
2971 void setFloat32(int byteOffset, double value) { 2971 void setFloat32(int byteOffset, double value) {
2972 if (byteOffset < 0 || byteOffset >= length) { 2972 if (byteOffset < 0 || byteOffset >= length) {
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
3081 return value; 3081 return value;
3082 } 3082 }
3083 return object; 3083 return object;
3084 } 3084 }
3085 3085
3086 3086
3087 void _throwRangeError(int index, int length) { 3087 void _throwRangeError(int index, int length) {
3088 String message = "$index must be in the range [0..$length)"; 3088 String message = "$index must be in the range [0..$length)";
3089 throw new RangeError(message); 3089 throw new RangeError(message);
3090 } 3090 }
OLDNEW
« no previous file with comments | « no previous file | tests/standalone/typed_data_view_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698