Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Unified Diff: runtime/lib/typeddata.dart

Issue 13516003: Fix the setters in _ByteDataView to behave the same as '[]=' and '[]' operators (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/standalone/typed_data_view_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/typeddata.dart
===================================================================
--- runtime/lib/typeddata.dart (revision 20878)
+++ runtime/lib/typeddata.dart (working copy)
@@ -2868,7 +2868,7 @@
if (byteOffset < 0 || byteOffset >= length) {
_throwRangeError(byteOffset, length);
}
- _typeddata._setInt8(_offset + byteOffset, value);
+ _typeddata._setInt8(_offset + byteOffset, _toInt8(value));
}
int getUint8(int byteOffset) {
@@ -2881,7 +2881,7 @@
if (byteOffset < 0 || byteOffset >= length) {
_throwRangeError(byteOffset, length);
}
- _typeddata._setUint8(_offset + byteOffset, value);
+ _typeddata._setUint8(_offset + byteOffset,_toUint8( value));
}
int getInt16(int byteOffset) {
@@ -2894,7 +2894,7 @@
if (byteOffset < 0 || byteOffset >= length) {
_throwRangeError(byteOffset, length);
}
- _typeddata._setInt16(_offset + byteOffset, value);
+ _typeddata._setInt16(_offset + byteOffset, _toInt16(value));
}
int getUint16(int byteOffset) {
@@ -2907,7 +2907,7 @@
if (byteOffset < 0 || byteOffset >= length) {
_throwRangeError(byteOffset, length);
}
- _typeddata._setUint16(_offset + byteOffset, value);
+ _typeddata._setUint16(_offset + byteOffset, _toUint16(value));
}
int getInt32(int byteOffset) {
@@ -2920,7 +2920,7 @@
if (byteOffset < 0 || byteOffset >= length) {
_throwRangeError(byteOffset, length);
}
- _typeddata._setInt32(_offset + byteOffset, value);
+ _typeddata._setInt32(_offset + byteOffset, _toInt32(value));
}
int getUint32(int byteOffset) {
@@ -2933,7 +2933,7 @@
if (byteOffset < 0 || byteOffset >= length) {
_throwRangeError(byteOffset, length);
}
- _typeddata._setUint32(_offset + byteOffset, value);
+ _typeddata._setUint32(_offset + byteOffset, _toUint32(value));
}
int getInt64(int byteOffset) {
@@ -2946,7 +2946,7 @@
if (byteOffset < 0 || byteOffset >= length) {
_throwRangeError(byteOffset, length);
}
- _typeddata._setInt64(_offset + byteOffset, value);
+ _typeddata._setInt64(_offset + byteOffset, _toInt64(value));
}
int getUint64(int byteOffset) {
@@ -2959,7 +2959,7 @@
if (byteOffset < 0 || byteOffset >= length) {
_throwRangeError(byteOffset, length);
}
- _typeddata._setUint64(_offset + byteOffset, value);
+ _typeddata._setUint64(_offset + byteOffset, _toUint64(value));
}
double getFloat32(int byteOffset) {
« no previous file with comments | « no previous file | tests/standalone/typed_data_view_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698