Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1348573004: dart2js: Don't return `null` from void functions. (Closed)

Created:
5 years, 3 months ago by floitsch
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org, Johnni Winther
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/js_ast/lib/src/template.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
5 years, 3 months ago (2015-09-21 22:01:04 UTC) #2
Siggi Cherem (dart-lang)
lgtm
5 years, 3 months ago (2015-09-21 22:06:16 UTC) #3
floitsch
5 years, 3 months ago (2015-09-22 09:10:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5461f0f5cd491b6e57d94315e63b55d7c98c5589 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698