Issue 1348573004: dart2js: Don't return `null` from void functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1348573004: dart2js: Don't return `null` from void functions. (Closed)

Created:
5 years, 3 months ago by floitsch

Modified:
5 years, 3 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, Johnni Winther

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	pkg/compiler/lib/src/elements/modelx.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	pkg/js_ast/lib/src/template.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

floitsch

5 years, 3 months ago (2015-09-22 09:10:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5461f0f5cd491b6e57d94315e63b55d7c98c5589 (presubmit successful).