pkg/compiler/lib/src/elements/modelx.dart - Issue 1348573004: dart2js: Don't return `null` from void functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/elements/modelx.dart

Issue 1348573004: dart2js: Don't return `null` from void functions. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/elements/modelx.dart

diff --git a/pkg/compiler/lib/src/elements/modelx.dart b/pkg/compiler/lib/src/elements/modelx.dart

index 8cf86c932c769ff3dd880bc266c86bf4ae06379c..50e0a588080c5b91cad25ed6e16a6bbe3559702b 100644

--- a/pkg/compiler/lib/src/elements/modelx.dart

+++ b/pkg/compiler/lib/src/elements/modelx.dart

@@ -1300,7 +1300,7 @@ abstract class ConstantVariableMixin implements VariableElement {

if (isPatch) {

ConstantVariableMixin originVariable = origin;

originVariable.constant = value;

- return null;

+ return;

}

assert(invariant(

this, constantCache == null || constantCache == value,

« no previous file with comments | « no previous file | pkg/js_ast/lib/src/template.dart » ('j') | no next file with comments »