Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: pkg/compiler/lib/src/elements/modelx.dart

Issue 1348573004: dart2js: Don't return `null` from void functions. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/js_ast/lib/src/template.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/elements/modelx.dart
diff --git a/pkg/compiler/lib/src/elements/modelx.dart b/pkg/compiler/lib/src/elements/modelx.dart
index 8cf86c932c769ff3dd880bc266c86bf4ae06379c..50e0a588080c5b91cad25ed6e16a6bbe3559702b 100644
--- a/pkg/compiler/lib/src/elements/modelx.dart
+++ b/pkg/compiler/lib/src/elements/modelx.dart
@@ -1300,7 +1300,7 @@ abstract class ConstantVariableMixin implements VariableElement {
if (isPatch) {
ConstantVariableMixin originVariable = origin;
originVariable.constant = value;
- return null;
+ return;
}
assert(invariant(
this, constantCache == null || constantCache == value,
« no previous file with comments | « no previous file | pkg/js_ast/lib/src/template.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698