Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: pkg/js_ast/lib/src/template.dart

Issue 1348573004: dart2js: Don't return `null` from void functions. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/compiler/lib/src/elements/modelx.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of js_ast; 5 part of js_ast;
6 6
7 class TemplateManager { 7 class TemplateManager {
8 Map<String, Template> expressionTemplates = new Map<String, Template>(); 8 Map<String, Template> expressionTemplates = new Map<String, Template>();
9 Map<String, Template> statementTemplates = new Map<String, Template>(); 9 Map<String, Template> statementTemplates = new Map<String, Template>();
10 10
(...skipping 747 matching lines...) Expand 10 before | Expand all | Expand 10 after
758 containsInterpolatedNode.contains(node); 758 containsInterpolatedNode.contains(node);
759 759
760 void visit(Node node) { 760 void visit(Node node) {
761 node.accept(this); 761 node.accept(this);
762 } 762 }
763 763
764 void visitNode(Node node) { 764 void visitNode(Node node) {
765 int before = count; 765 int before = count;
766 node.visitChildren(this); 766 node.visitChildren(this);
767 if (count != before) containsInterpolatedNode.add(node); 767 if (count != before) containsInterpolatedNode.add(node);
768 return null;
769 } 768 }
770 769
771 visitInterpolatedNode(InterpolatedNode node) { 770 visitInterpolatedNode(InterpolatedNode node) {
772 containsInterpolatedNode.add(node); 771 containsInterpolatedNode.add(node);
773 if (node.isNamed) holeNames.add(node.nameOrPosition); 772 if (node.isNamed) holeNames.add(node.nameOrPosition);
774 ++count; 773 ++count;
775 } 774 }
776 } 775 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/elements/modelx.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698