Issue 13483018: Introduces a second temporary register for MIPS assembler macros.

Issue 13483018: Introduces a second temporary register for MIPS assembler macros. (Closed)

Created:
7 years, 8 months ago by zra

Modified:
7 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Introduces a second temporary register for MIPS assembler macros. - Also, adds macros for comparisons followed by branches, and uses them. Committed: https://code.google.com/p/dart/source/detail?r=21118

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+212 lines, -145 lines)			Patch
M	runtime/vm/assembler_mips.h	View	1 2	9 chunks	+111 lines, -33 lines	0 comments	Download
M	runtime/vm/assembler_mips.cc	View		4 chunks	+31 lines, -31 lines	0 comments	Download
M	runtime/vm/assembler_mips_test.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	runtime/vm/constants_mips.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1 2	17 chunks	+29 lines, -40 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 2	2 chunks	+4 lines, -6 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1 2	5 chunks	+32 lines, -32 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM with one comment. https://codereview.chromium.org/13483018/diff/4001/runtime/vm/assembler_mips.h File runtime/vm/assembler_mips.h (right): https://codereview.chromium.org/13483018/diff/4001/runtime/vm/assembler_mips.h#newcode568 runtime/vm/assembler_mips.h:568: void BranchEq(Register rd, int32_t value, ...

7 years, 8 months ago (2013-04-08 21:41:18 UTC) #2

zra

Thanks! https://codereview.chromium.org/13483018/diff/4001/runtime/vm/assembler_mips.h File runtime/vm/assembler_mips.h (right): https://codereview.chromium.org/13483018/diff/4001/runtime/vm/assembler_mips.h#newcode568 runtime/vm/assembler_mips.h:568: void BranchEq(Register rd, int32_t value, Label* l) { ...

7 years, 8 months ago (2013-04-08 22:04:12 UTC) #3

zra

7 years, 8 months ago (2013-04-08 22:04:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r21118 (presubmit successful).

Expand Messages | Collapse Messages