runtime/vm/assembler_mips_test.cc - Issue 13483018: Introduces a second temporary register for MIPS assembler macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_mips_test.cc

Issue 13483018: Introduces a second temporary register for MIPS assembler macros. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/assembler_mips_test.cc

===================================================================

--- runtime/vm/assembler_mips_test.cc (revision 21085)

+++ runtime/vm/assembler_mips_test.cc (working copy)

@@ -1047,7 +1047,6 @@

- Register scratch = T4;

Label error, done;

__ LoadImmediate(V0, 1); // Success value.

@@ -1082,7 +1081,7 @@

__ bgez(overflow, &error); // INT_MIN - 1 overflows.

// result has 0x7fffffff.

- __ AdduDetectOverflow(result, result, result, overflow, scratch);

+ __ AdduDetectOverflow(result, result, result, overflow);

__ bgez(overflow, &error); // INT_MAX + INT_MAX overflows.

__ LoadImmediate(left, 0x80000000);

« no previous file with comments | « runtime/vm/assembler_mips.cc ('k') | runtime/vm/constants_mips.h » ('j') | no next file with comments »