Add related types check to analyze_dart2js_test

Add related types check to analyze_dart2js_test

BUG=
R=sigurdm@google.com

Committed: https://github.com/dart-lang/sdk/commit/7407a72115d94685975c628ea3097ff5af795682

[Johnni Winther, 2015-09-11 09:19:14]

johnniwinther@google.com changed reviewers:
+ sigurdm@google.com

[Johnni Winther, 2015-09-11 09:19:15]

https://codereview.chromium.org/1338683002/diff/40001/pkg/compiler/lib/src/da...
File pkg/compiler/lib/src/dart_types.dart (right):

https://codereview.chromium.org/1338683002/diff/40001/pkg/compiler/lib/src/da...
pkg/compiler/lib/src/dart_types.dart:1667: 
Extracted from typechecker.dart

[sigurdm, 2015-09-11 11:43:29]

LGTM

https://codereview.chromium.org/1338683002/diff/40001/pkg/compiler/lib/src/da...
File pkg/compiler/lib/src/dart_types.dart (right):

https://codereview.chromium.org/1338683002/diff/40001/pkg/compiler/lib/src/da...
pkg/compiler/lib/src/dart_types.dart:1685: /// Computes the interface type of
[type]. For type variable it is the
For *a* type variable

https://codereview.chromium.org/1338683002/diff/40001/pkg/compiler/lib/src/da...
pkg/compiler/lib/src/dart_types.dart:1687: /// `Function` type.
To me it doesn't seem like type-variables are treated differently. Is this
comment correct?

https://codereview.chromium.org/1338683002/diff/40001/pkg/compiler/lib/src/da...
pkg/compiler/lib/src/dart_types.dart:1690: type =
compiler.functionClass.rawType;
Wrong indentation

https://codereview.chromium.org/1338683002/diff/40001/tests/compiler/dart2js/...
File tests/compiler/dart2js/related_types.dart (right):

https://codereview.chromium.org/1338683002/diff/40001/tests/compiler/dart2js/...
tests/compiler/dart2js/related_types.dart:5: library related_types;
Do we want to also provide these hints outside dart2js?

https://codereview.chromium.org/1338683002/diff/40001/tests/compiler/dart2js/...
tests/compiler/dart2js/related_types.dart:17: /// Check all loader libraries in
[compiler] for unrelated types.
loader => loaded

[Johnni Winther, 2015-09-11 12:31:22]

https://codereview.chromium.org/1338683002/diff/40001/pkg/compiler/lib/src/da...
File pkg/compiler/lib/src/dart_types.dart (right):

https://codereview.chromium.org/1338683002/diff/40001/pkg/compiler/lib/src/da...
pkg/compiler/lib/src/dart_types.dart:1685: /// Computes the interface type of
[type]. For type variable it is the
On 2015/09/11 11:43:28, sigurdm wrote:
> For *a* type variable

Done.

https://codereview.chromium.org/1338683002/diff/40001/pkg/compiler/lib/src/da...
pkg/compiler/lib/src/dart_types.dart:1687: /// `Function` type.
On 2015/09/11 11:43:28, sigurdm wrote:
> To me it doesn't seem like type-variables are treated differently. Is this
> comment correct?

This wrong. The type is assumed not to be a type variable.

https://codereview.chromium.org/1338683002/diff/40001/pkg/compiler/lib/src/da...
pkg/compiler/lib/src/dart_types.dart:1690: type =
compiler.functionClass.rawType;
On 2015/09/11 11:43:28, sigurdm wrote:
> Wrong indentation

Done.

https://codereview.chromium.org/1338683002/diff/40001/tests/compiler/dart2js/...
File tests/compiler/dart2js/related_types.dart (right):

https://codereview.chromium.org/1338683002/diff/40001/tests/compiler/dart2js/...
tests/compiler/dart2js/related_types.dart:5: library related_types;
On 2015/09/11 11:43:28, sigurdm wrote:
> Do we want to also provide these hints outside dart2js?

Potentially, as an opt-in.

https://codereview.chromium.org/1338683002/diff/40001/tests/compiler/dart2js/...
tests/compiler/dart2js/related_types.dart:17: /// Check all loader libraries in
[compiler] for unrelated types.
On 2015/09/11 11:43:28, sigurdm wrote:
> loader => loaded

Done.

[Johnni Winther, 2015-09-11 12:38:13]

Committed patchset #4 (id:60001) manually as
7407a72115d94685975c628ea3097ff5af795682 (presubmit successful).