pkg/js_ast/lib/src/printer.dart - Issue 1338683002: Add related types check to analyze_dart2js_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/js_ast/lib/src/printer.dart

Issue 1338683002: Add related types check to analyze_dart2js_test (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/js_ast/lib/src/printer.dart

diff --git a/pkg/js_ast/lib/src/printer.dart b/pkg/js_ast/lib/src/printer.dart

index 85239163b11f5ba3847fd09dbc9146a9cfc7ce76..7a1124f744580a4887f4c612bab17b7518b7e736 100644

--- a/pkg/js_ast/lib/src/printer.dart

+++ b/pkg/js_ast/lib/src/printer.dart

@@ -136,7 +136,7 @@ class Printer implements NodeVisitor {

int get lastCharCode {

if (lastAddedString == null) return 0;

- assert(lastAddedString.length != "");

+ assert(lastAddedString.length != 0);

return lastAddedString.codeUnitAt(lastAddedString.length - 1);

}

« no previous file with comments | « pkg/compiler/lib/src/world.dart ('k') | tests/compiler/dart2js/analyze_dart2js_test.dart » ('j') | no next file with comments »