Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: tests/compiler/dart2js/analyze_dart2js_test.dart

Issue 1338683002: Add related types check to analyze_dart2js_test (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/js_ast/lib/src/printer.dart ('k') | tests/compiler/dart2js/memory_compiler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/analyze_dart2js_test.dart
diff --git a/tests/compiler/dart2js/analyze_dart2js_test.dart b/tests/compiler/dart2js/analyze_dart2js_test.dart
index 602f904b7e0fa991ca7e81eabd36f7cccc82e689..f5fc77c444a429e7b0daeabe97ae7e4cd06d9407 100644
--- a/tests/compiler/dart2js/analyze_dart2js_test.dart
+++ b/tests/compiler/dart2js/analyze_dart2js_test.dart
@@ -4,9 +4,11 @@
library analyze_dart2js;
+import 'package:async_helper/async_helper.dart';
import 'package:compiler/src/filenames.dart';
+import 'package:compiler/src/compiler.dart';
import 'analyze_helper.dart';
-import "package:async_helper/async_helper.dart";
+import 'related_types.dart';
/**
* Map of whitelisted warnings and errors.
@@ -24,5 +26,11 @@ const Map<String,List<String>> WHITE_LIST = const {
void main() {
var uri = currentDirectory.resolve('pkg/compiler/lib/src/dart2js.dart');
- asyncTest(() => analyze([uri], WHITE_LIST));
+ asyncTest(() => analyze([uri], WHITE_LIST, checkResults: checkResults));
}
+
+bool checkResults(Compiler compiler,
+ CollectingDiagnosticHandler handler) {
+ checkRelatedTypes(compiler);
+ return !handler.hasHint;
+}
« no previous file with comments | « pkg/js_ast/lib/src/printer.dart ('k') | tests/compiler/dart2js/memory_compiler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698