Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 13375022: Split up some slow pub tests and mark some scheduled_test tests as slow. (Closed)

Created:
7 years, 8 months ago by nweiz
Modified:
7 years, 8 months ago
Reviewers:
Andrei Mouravski
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Split up some slow pub tests and mark some scheduled_test tests as slow. BUG=9231 Committed: https://code.google.com/p/dart/source/detail?r=20758

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1653 lines, -1077 lines) Patch
M pkg/pkg.status View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/scheduled_test/test/scheduled_server_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A utils/tests/pub/lish/archives_and_uploads_a_package_test.dart View 1 chunk +45 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/cloud_storage_upload_doesnt_redirect_test.dart View 1 chunk +38 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/cloud_storage_upload_provides_an_error_test.dart View 1 chunk +45 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/force_cannot_be_combined_with_dry_run_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/force_does_not_publish_if_there_are_errors_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/force_publishes_if_tests_are_no_warnings_or_errors_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/force_publishes_if_there_are_warnings_test.dart View 1 chunk +45 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/package_creation_provides_a_malformed_error_test.dart View 1 chunk +38 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/package_creation_provides_a_malformed_success_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/package_creation_provides_an_error_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/package_creation_provides_invalid_json_test.dart View 1 chunk +36 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/package_validation_has_a_warning_and_continues_test.dart View 1 chunk +41 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/package_validation_has_a_warning_and_is_canceled_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/package_validation_has_an_error_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/preview_package_validation_has_a_warning_test.dart View 1 chunk +33 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/preview_package_validation_has_no_warnings_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/upload_form_fields_has_a_non_string_value_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/upload_form_fields_is_not_a_map_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/upload_form_is_missing_fields_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/upload_form_is_missing_url_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/upload_form_provides_an_error_test.dart View 1 chunk +36 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/upload_form_provides_invalid_json_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/upload_form_url_is_not_a_string_test.dart View 1 chunk +38 lines, -0 lines 0 comments Download
A utils/tests/pub/lish/utils.dart View 1 chunk +54 lines, -0 lines 0 comments Download
D utils/tests/pub/pub_lish_test.dart View 1 chunk +0 lines, -491 lines 0 comments Download
A utils/tests/pub/validator/compiled_dartdoc_test.dart View 1 chunk +54 lines, -0 lines 0 comments Download
A utils/tests/pub/validator/dependency_test.dart View 1 chunk +250 lines, -0 lines 0 comments Download
A utils/tests/pub/validator/directory_test.dart View 1 chunk +46 lines, -0 lines 0 comments Download
A utils/tests/pub/validator/lib_test.dart View 1 chunk +62 lines, -0 lines 0 comments Download
A utils/tests/pub/validator/license_test.dart View 1 chunk +51 lines, -0 lines 0 comments Download
A utils/tests/pub/validator/name_test.dart View 1 chunk +107 lines, -0 lines 0 comments Download
A utils/tests/pub/validator/pubspec_field_test.dart View 1 chunk +102 lines, -0 lines 0 comments Download
utils/tests/pub/validator/size_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download
A utils/tests/pub/validator/utf8_readme_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download
A utils/tests/pub/validator/utils.dart View 1 chunk +23 lines, -0 lines 0 comments Download
utils/tests/pub/validator_test.dart View 1 chunk +0 lines, -584 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
TBR
7 years, 8 months ago (2013-04-01 23:19:43 UTC) #1
nweiz
Committed patchset #1 manually as r20758 (presubmit successful).
7 years, 8 months ago (2013-04-01 23:20:24 UTC) #2
Andrei Mouravski
On 2013/04/01 23:20:24, nweiz wrote: > Committed patchset #1 manually as r20758 (presubmit successful). lgtm ...
7 years, 8 months ago (2013-04-01 23:53:27 UTC) #3
nweiz
7 years, 8 months ago (2013-04-01 23:54:38 UTC) #4
Message was sent while issue was closed.
On 2013/04/01 23:53:27, Andrei Mouravski wrote:
> On 2013/04/01 23:20:24, nweiz wrote:
> > Committed patchset #1 manually as r20758 (presubmit successful).
> lgtm
> 
> In the future, it's convenient if you first git cl upload the initital
(broken)
> change, and then upload your changes on top, so there's a clear diff.

I don't follow... what initial change?

Powered by Google App Engine
This is Rietveld 408576698